-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot read property 'Symbol(kNativeFields)' using http2 session removeAllListeners #29457
Labels
http2
Issues or PRs related to the http2 subsystem.
Comments
Thanks for the bug report. This shouldn’t be too hard to fix, but a full reproduction would still be appreciated (just calling |
Ah, nvm, it just needs an additional listener for |
addaleax
added a commit
to addaleax/node
that referenced
this issue
Sep 5, 2019
Do not crash when the session is no longer available. Fixes: nodejs#29457
3 tasks
addaleax
added a commit
to addaleax/node
that referenced
this issue
Sep 19, 2019
Do not crash when the session is no longer available. Fixes: nodejs#29457 PR-URL: nodejs#29459 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
added a commit
to addaleax/node
that referenced
this issue
Sep 19, 2019
Do not crash when the session is no longer available. Fixes: nodejs#29457 PR-URL: nodejs#29459 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs
pushed a commit
that referenced
this issue
Sep 25, 2019
Do not crash when the session is no longer available. Fixes: #29457 PR-URL: #29459 Backport-PR-URL: #29618 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs
pushed a commit
that referenced
this issue
Oct 1, 2019
Do not crash when the session is no longer available. Fixes: #29457 PR-URL: #29459 Backport-PR-URL: #29619 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using the removeAllListeners on a http2 stream inside an on("close"...) generates this error
The code generating it is:
The text was updated successfully, but these errors were encountered: