-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clang10 is unsupported #29536
Comments
PR welcome. Your suggested change seems reasonable but I'd mirror the regex from Lines 729 to 731 in b354d12
|
Detected on NetBSD/amd64. Fixes: nodejs#29536
Detected on NetBSD/amd64. Fixes: #29536 PR-URL: #29541 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Detected on NetBSD/amd64. Fixes: #29536 PR-URL: #29541 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This issue is still present on v10.x, the fix needs backporting: EDIT: "cherrypicking"
|
Detected on NetBSD/amd64. Fixes: nodejs#29536 PR-URL: nodejs#29541 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Detected on NetBSD/amd64. Fixes: #29536 PR-URL: #29541 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
It appears that a patch has made its way onto the master branch but did not make it to the 14.4.0 release. Does anyone know if its going to ported to that release line? Edit: Jk apparently it is there. I am still having issues getting alpine with clang to build though. Should not the assembler be set to Here's been my experience on alpine using its clang's compiled package:
But according to the As such, get_llvm_version always returns '0.0', and the assembler check fails. I'm unsure what the output of other clang-compiled packages report on other systems for EDIT: Here's what
It seems like maybe the regexp is getting messed up in alpine perhaps because of its looking for In any case, this seems like it probably is boiling down to package maintainers at this point. If someone could confirm that I'm right and which version output is the desired one I would be happy to report this up to the alpine linux folks. |
https://gitlab.alpinelinux.org/alpine/aports/-/issues/11640 Here's a thread/issue I started RE: the compilation on an alpine system. I think perhaps there is an even more optimal approach to take with the regexp used in the I can also add that Apple adds a clang vendor to their version, it seems; though I don't know how nodejs is compiled to run on OSX:
|
Thu Sep 12 17:55:54 CEST 2019
clang10 (svn snapshot) is unsupported
Culrpit code in configure.py:
This patch fixes the problem for me:
Maybe it would be reasonable to accept all LLVM versions now.
The text was updated successfully, but these errors were encountered: