-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future work for source-map functionality #29865
Comments
Thanks @bcoe! I’m excited to help out with some of this stuff. |
Hello @bcoe I'm a first time contributor here and would love to help out with this, how can I begin ? |
@Hamza-324 I would love for us to figure out a way for source maps to work when running in a repl, this might be the easiest place to start contributing on the feature. |
@bcoe okay, I will start work on this. |
@Hamza-324 yes 👍 happy to help coordinate here. |
From this conversation we may want to reconsider our approach of showing both the original and transpiled call site, as it might not fit with the TC39 Error Stacks Proposal. We should start a conversation about the future of Node.js' stack traces/source map support, on this proposal. CC: @ljharb |
This thread documents some of the known limitations of the recently released Source Map V3 support in Node.js.
I would greatly appreciate help testing and improving this feature, and this is a great opportunity to land some commits in Node.js.
If you begin work on a specific task, create a corresponding issue and reference this thread.
Feature Work
^
pointing to the source location where an exception occurred. (@bcoe might be able to help).Bug Fixes
partial source-map/coverage is written to disk when running Node's test suite (
make -j4 coverage-run-js
, results in warningSyntaxError: Unexpected end of JSON input
) (potentially talk to @joyeecheung about this issue).missing branch coverage displayed for covered catch statements (the fix for this is most likely in v8, and similar to this, @schuay would be a good person to talk to about this).
Refactoring
WeakMap
for both, and still serialize to disk?).CC: @iansu, @azasypkin
Related: related Node tooling conversation.
The text was updated successfully, but these errors were encountered: