Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thrown an Error from queueMicrotask's callback aborted the process #30080

Closed
abbshr opened this issue Oct 23, 2019 · 1 comment
Closed

Thrown an Error from queueMicrotask's callback aborted the process #30080

abbshr opened this issue Oct 23, 2019 · 1 comment
Labels
async_hooks Issues and PRs related to the async hooks subsystem. confirmed-bug Issues with confirmed bugs.

Comments

@abbshr
Copy link
Contributor

abbshr commented Oct 23, 2019

  • Version: v12.13.0

  • Subsystem: global

  • Platform: Linux rankong-wacai-env 4.9.125-linuxkit #1 SMP Fri Sep 7 08:20:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

image

  • Platform: Darwin RanWithMeow-RMPB 18.7.0 Darwin Kernel Version 18.7.0: Tue Aug 20 16:57:14 PDT 2019; root:xnu-4903.271.2~2/RELEASE_X86_64 x86_64

image
@addaleax addaleax added confirmed-bug Issues with confirmed bugs. domain Issues and PRs related to the domain subsystem. async_hooks Issues and PRs related to the async hooks subsystem. and removed domain Issues and PRs related to the domain subsystem. labels Oct 23, 2019
addaleax added a commit to addaleax/node that referenced this issue Oct 23, 2019
@addaleax
async_hooks: only emit after for AsyncResource if stack not empty
dddc895 
We clear the async id stack inside the uncaught exception handler and
emit `after` events in the process, so we should not emit `after`
a second time from the `runInAsyncScope()` code.

This should match the behaviour we have in C++.

Fixes: nodejs#30080
@addaleax addaleax mentioned this issue Oct 23, 2019
Closed
3 tasks
@addaleax
Copy link
Member

Thanks, #30087 should fix this :)

targos pushed a commit that referenced this issue Oct 28, 2019
@addaleax @targos
async_hooks: only emit after for AsyncResource if stack not empty
4458378 
We clear the async id stack inside the uncaught exception handler and
emit `after` events in the process, so we should not emit `after`
a second time from the `runInAsyncScope()` code.

This should match the behaviour we have in C++.

Fixes: #30080

PR-URL: #30087
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
targos pushed a commit that referenced this issue Nov 8, 2019
@addaleax @targos
async_hooks: only emit after for AsyncResource if stack not empty
25eda79 
We clear the async id stack inside the uncaught exception handler and
emit `after` events in the process, so we should not emit `after`
a second time from the `runInAsyncScope()` code.

This should match the behaviour we have in C++.

Fixes: #30080

PR-URL: #30087
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
targos pushed a commit that referenced this issue Nov 10, 2019
@addaleax @targos
async_hooks: only emit after for AsyncResource if stack not empty
8159579 
We clear the async id stack inside the uncaught exception handler and
emit `after` events in the process, so we should not emit `after`
a second time from the `runInAsyncScope()` code.

This should match the behaviour we have in C++.

Fixes: #30080

PR-URL: #30087
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
targos pushed a commit that referenced this issue Nov 10, 2019
@addaleax @targos
async_hooks: only emit after for AsyncResource if stack not empty
f56abb5 
We clear the async id stack inside the uncaught exception handler and
emit `after` events in the process, so we should not emit `after`
a second time from the `runInAsyncScope()` code.

This should match the behaviour we have in C++.

Fixes: #30080

PR-URL: #30087
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
targos pushed a commit that referenced this issue Nov 11, 2019
@addaleax @targos
async_hooks: only emit after for AsyncResource if stack not empty
56be32d 
We clear the async id stack inside the uncaught exception handler and
emit `after` events in the process, so we should not emit `after`
a second time from the `runInAsyncScope()` code.

This should match the behaviour we have in C++.

Fixes: #30080

PR-URL: #30087
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. confirmed-bug Issues with confirmed bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

async_hooks: only emit after for AsyncResource if stack not empty addaleax/node
2 participants
@addaleax @abbshr