Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use libnghttp2.pc instead of nghttp2.pc #30113

Closed
dilyanpalauzov opened this issue Oct 25, 2019 · 4 comments
Closed

Use libnghttp2.pc instead of nghttp2.pc #30113

dilyanpalauzov opened this issue Oct 25, 2019 · 4 comments
Labels
build Issues and PRs related to build files or the CI.

Comments

@dilyanpalauzov
Copy link

With 12.13.0 ./configure --help prints:

    --shared-nghttp2    link to a shared nghttp2 DLL instead of static linking
    --shared-nghttp2-includes=SHARED_NGHTTP2_INCLUDES
                        directory containing nghttp2 header files
    --shared-nghttp2-libname=SHARED_NGHTTP2_LIBNAME
                        alternative lib name to link to [default: nghttp2]
    --shared-nghttp2-libpath=SHARED_NGHTTP2_LIBPATH
                        a directory to search for the shared nghttp2 DLLs

nghttp2-1.39.2 installs libnghttp2.pc but not libnghttp2.pc . On my system pkg-config libnghttp2.pc --libs works and pkg-config nghttp2.pc --libs does not work.

./configure --shared-nghttp2 prints on my system:

Package nghttp2 was not found in the pkg-config search path.
Perhaps you should add the directory containing `nghttp2.pc'
to the PKG_CONFIG_PATH environment variable
No package 'nghttp2' found

Apparently, ./configure has to search for libnghttp2.pc, but looks for nghttp2.pc.
@bnoordhuis bnoordhuis added the build Issues and PRs related to build files or the CI. label Oct 27, 2019
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Oct 27, 2019
@bnoordhuis
build: fix pkg-config search for libnghttp2
70d6ca9 
The configure script was searching for 'nghttp2' whereas the actual name
of the package is 'libnghttp2'.

This change also removes the hack for libcares in one fell swoop.

Fixes: nodejs#30113
@bnoordhuis bnoordhuis mentioned this issue Oct 27, 2019
Closed
@bnoordhuis
Copy link
Member

Can you check whether #30145 resolves the issue for you?

@dilyanpalauzov
Copy link
Author

Now it prints

Package libhttp2 was not found in the pkg-config search path.
Perhaps you should add the directory containing `libhttp2.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libhttp2' found

Apparently it searches for libhttp2.pc, but should look for libnghttp2.pc.

@bnoordhuis
Copy link
Member

Yeah, somehow a typo snuck in. The last version of the PR should be good to go.

@danbev danbev closed this as completed in efb406c Oct 31, 2019
@dilyanpalauzov
Copy link
Author

Now it works as expected.

targos pushed a commit that referenced this issue Nov 5, 2019
@bnoordhuis @targos
build: fix pkg-config search for libnghttp2
b255688 
The configure script was searching for 'nghttp2' whereas the actual name
of the package is 'libnghttp2'.

This change also removes the hack for libcares in one fell swoop.

Co-Authored-By: legendecas <legendecas@gmail.com>

PR-URL: #30145
Fixes: #30113
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos pushed a commit that referenced this issue Nov 8, 2019
@bnoordhuis @targos
build: fix pkg-config search for libnghttp2
85503bf 
The configure script was searching for 'nghttp2' whereas the actual name
of the package is 'libnghttp2'.

This change also removes the hack for libcares in one fell swoop.

Co-Authored-By: legendecas <legendecas@gmail.com>

PR-URL: #30145
Fixes: #30113
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos pushed a commit that referenced this issue Nov 10, 2019
@bnoordhuis @targos
build: fix pkg-config search for libnghttp2
bb42698 
The configure script was searching for 'nghttp2' whereas the actual name
of the package is 'libnghttp2'.

This change also removes the hack for libcares in one fell swoop.

Co-Authored-By: legendecas <legendecas@gmail.com>

PR-URL: #30145
Fixes: #30113
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos pushed a commit that referenced this issue Nov 10, 2019
@bnoordhuis @targos
build: fix pkg-config search for libnghttp2
08ad146 
The configure script was searching for 'nghttp2' whereas the actual name
of the package is 'libnghttp2'.

This change also removes the hack for libcares in one fell swoop.

Co-Authored-By: legendecas <legendecas@gmail.com>

PR-URL: #30145
Fixes: #30113
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos pushed a commit that referenced this issue Nov 11, 2019
@bnoordhuis @targos
build: fix pkg-config search for libnghttp2
468f203 
The configure script was searching for 'nghttp2' whereas the actual name
of the package is 'libnghttp2'.

This change also removes the hack for libcares in one fell swoop.

Co-Authored-By: legendecas <legendecas@gmail.com>

PR-URL: #30145
Fixes: #30113
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: fix pkg-config search for libnghttp2 bnoordhuis/io.js
2 participants
@bnoordhuis @dilyanpalauzov