-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errors with --experimental-loader trigger unhandled rejections in core #30205
Labels
confirmed-bug
Issues with confirmed bugs.
esm
Issues and PRs related to the ECMAScript Modules implementation.
Comments
targos
added
confirmed-bug
Issues with confirmed bugs.
esm
Issues and PRs related to the ECMAScript Modules implementation.
labels
Nov 1, 2019
Great to see these, thanks. It seems like the issue is that the promise catch handler at https://github.com/nodejs/node/blob/master/lib/internal/bootstrap/pre_execution.js#L484 should be moved up one level to also be able to catch the |
targos
added a commit
to targos/node
that referenced
this issue
Nov 2, 2019
Previously, this would trigger an unhandled rejection that the user cannot handle. Fixes: nodejs#30205
3 tasks
Fix: #30219 |
MylesBorins
pushed a commit
that referenced
this issue
Nov 17, 2019
Previously, this would trigger an unhandled rejection that the user cannot handle. Fixes: #30205 PR-URL: #30219 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
MylesBorins
pushed a commit
that referenced
this issue
Jan 12, 2020
Previously, this would trigger an unhandled rejection that the user cannot handle. Fixes: #30205 PR-URL: #30219 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
BethGriggs
pushed a commit
that referenced
this issue
Feb 6, 2020
Previously, this would trigger an unhandled rejection that the user cannot handle. Fixes: #30205 PR-URL: #30219 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
confirmed-bug
Issues with confirmed bugs.
esm
Issues and PRs related to the ECMAScript Modules implementation.
The text was updated successfully, but these errors were encountered: