Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate flaky parallel/test-readline-async-iterators-destroy in CI #30660

Closed
gireeshpunathil opened this issue Nov 26, 2019 · 1 comment
Closed

investigate flaky parallel/test-readline-async-iterators-destroy in CI #30660

gireeshpunathil opened this issue Nov 26, 2019 · 1 comment
Labels
confirmed-bug Issues with confirmed bugs. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system.

Comments

@gireeshpunathil
Copy link
Member

  • Version: master
  • Platform: linux-containerized
  • Subsystem: readline
not ok 1632 parallel/test-readline-async-iterators-destroy
  ---
  duration_ms: 0.177
  severity: fail
  exitcode: 1
  stack: |-
    events.js:194
          throw er; // Unhandled 'error' event
          ^
    
    Error: EBADF: bad file descriptor, read
    Emitted 'error' event on ReadStream instance at:
        at internal/fs/streams.js:183:12
        at FSReqCallback.wrapper [as oncomplete] (fs.js:480:5) {
      errno: -9,
      code: 'EBADF',
      syscall: 'read'
    }
  ...

ref: https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_openssl111_x64/16239/consoleText
This was referenced Nov 26, 2019
Closed
Closed
@devsnek devsnek added flaky-test Issues and PRs related to the tests with unstable failures on the CI. readline Issues and PRs related to the built-in readline module. labels Dec 3, 2019
@BridgeAR BridgeAR mentioned this issue Dec 6, 2019
Closed
4 tasks
@addaleax addaleax added confirmed-bug Issues with confirmed bugs. fs Issues and PRs related to the fs subsystem / file system. and removed readline Issues and PRs related to the built-in readline module. labels Dec 6, 2019
addaleax added a commit to addaleax/node that referenced this issue Dec 7, 2019
@addaleax
test: wait for stream close before writing to file
a118f9b 
Wait for async operations on a file to finish before writing to it
again.

This fixes flakiness in parallel/test-readline-async-iterators-destroy.

Refs: nodejs#30660
This was referenced Dec 7, 2019
Closed
Closed
@addaleax
Copy link
Member

addaleax commented Dec 7, 2019

This should be fixed by #30836 + #30837 (they are two fully unrelated issues, that’s why it’s 2 PRs)

addaleax added a commit to addaleax/node that referenced this issue Dec 9, 2019
@addaleax
fs: synchronize close with other I/O for streams
b1f7bf0 
Part of the flakiness in the
parallel/test-readline-async-iterators-destroy test comes from
fs streams starting `_read()` and `_destroy()` without waiting
for the other to finish, which can lead to the `fs.read()` call
resulting in `EBADF` if timing is bad.

Fix this by synchronizing write and read operations with `close()`.

Refs: nodejs#30660
addaleax added a commit that referenced this issue Dec 10, 2019
@addaleax
fs: synchronize close with other I/O for streams
8a5c7f6 
Part of the flakiness in the
parallel/test-readline-async-iterators-destroy test comes from
fs streams starting `_read()` and `_destroy()` without waiting
for the other to finish, which can lead to the `fs.read()` call
resulting in `EBADF` if timing is bad.

Fix this by synchronizing write and read operations with `close()`.

Refs: #30660

PR-URL: #30837
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue Dec 11, 2019
@addaleax @targos
fs: synchronize close with other I/O for streams
6c07a72 
Part of the flakiness in the
parallel/test-readline-async-iterators-destroy test comes from
fs streams starting `_read()` and `_destroy()` without waiting
for the other to finish, which can lead to the `fs.read()` call
resulting in `EBADF` if timing is bad.

Fix this by synchronizing write and read operations with `close()`.

Refs: #30660

PR-URL: #30837
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue Dec 11, 2019
@addaleax @targos
test: wait for stream close before writing to file
ce21fc7 
Wait for async operations on a file to finish before writing to it
again.

This fixes flakiness in parallel/test-readline-async-iterators-destroy.

PR-URL: #30836
Fixes: #30660
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@thangktran thangktran mentioned this issue Dec 11, 2019
Closed
4 tasks
targos pushed a commit that referenced this issue Jan 14, 2020
@addaleax @targos
fs: synchronize close with other I/O for streams
c3daa3e 
Part of the flakiness in the
parallel/test-readline-async-iterators-destroy test comes from
fs streams starting `_read()` and `_destroy()` without waiting
for the other to finish, which can lead to the `fs.read()` call
resulting in `EBADF` if timing is bad.

Fix this by synchronizing write and read operations with `close()`.

Refs: #30660

PR-URL: #30837
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue Jan 14, 2020
@addaleax @targos
test: wait for stream close before writing to file
bf9a824 
Wait for async operations on a file to finish before writing to it
again.

This fixes flakiness in parallel/test-readline-async-iterators-destroy.

PR-URL: #30836
Fixes: #30660
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BethGriggs pushed a commit that referenced this issue Feb 6, 2020
@addaleax @BethGriggs
fs: synchronize close with other I/O for streams
578d12f 
Part of the flakiness in the
parallel/test-readline-async-iterators-destroy test comes from
fs streams starting `_read()` and `_destroy()` without waiting
for the other to finish, which can lead to the `fs.read()` call
resulting in `EBADF` if timing is bad.

Fix this by synchronizing write and read operations with `close()`.

Refs: #30660

PR-URL: #30837
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this issue Feb 6, 2020
@addaleax @BethGriggs
test: wait for stream close before writing to file
5bffe11 
Wait for async operations on a file to finish before writing to it
again.

This fixes flakiness in parallel/test-readline-async-iterators-destroy.

PR-URL: #30836
Fixes: #30660
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: wait for stream close before writing to file addaleax/node
3 participants
@addaleax @devsnek @gireeshpunathil