-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto.randomBytes documentation needs improvement #3081
Labels
crypto
Issues and PRs related to the crypto subsystem.
doc
Issues and PRs related to the documentations.
good first issue
Issues that are suitable for first-time contributors.
Comments
brendanashworth
added
crypto
Issues and PRs related to the crypto subsystem.
doc
Issues and PRs related to the documentations.
labels
Sep 26, 2015
brendanashworth
added
the
good first issue
Issues that are suitable for first-time contributors.
label
Sep 27, 2015
brendanashworth
changed the title
doc: crypto.randomBytes documentation needs improvement
crypto.randomBytes documentation needs improvement
Sep 27, 2015
@brendanashworth I will take care of this :) |
ref: #3087 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
crypto
Issues and PRs related to the crypto subsystem.
doc
Issues and PRs related to the documentations.
good first issue
Issues that are suitable for first-time contributors.
The
crypto.randomBytes
documentation is quite confusing on whether or not the function throws on a lack of entropy. The code shows that it does, but the note below says that it does not. I'm currently under the impression that it does not throw on low entropy, so this needs to be fixed. Here is how it looks now:Refs to: #3073 (comment) and following discussion, e5e5980, f68a116, and
RAND_bytes()
docs. Also #813.The text was updated successfully, but these errors were encountered: