Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test parallel/test-module-loading-globalpaths #30844

Open
joaocgreis opened this issue Dec 8, 2019 · 3 comments
Open

Investigate flaky test parallel/test-module-loading-globalpaths #30844

joaocgreis opened this issue Dec 8, 2019 · 3 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@joaocgreis
Copy link
Member

  • Version: master
  • Platform: Windows
  • Subsystem: test
internal/modules/cjs/loader.js:1026
    throw err;
    ^

Error: Cannot find module 'foo'
Require stack:
- C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-module-loading-globalpaths.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:1023:17)
    at Function.Module._load (internal/modules/cjs/loader.js:910:27)
    at Module.require (internal/modules/cjs/loader.js:1085:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-module-loading-globalpaths.js:15:15)
    at Module._compile (internal/modules/cjs/loader.js:1190:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1229:10)
    at Module.load (internal/modules/cjs/loader.js:1045:32)
    at Function.Module._load (internal/modules/cjs/loader.js:949:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    'C:\\workspace\\node-test-binary-windows-js-suites\\node\\test\\parallel\\test-module-loading-globalpaths.js'
  ]
}
C:\workspace\node-test-binary-windows-js-suites\node\test\.tmp.355\install\node.exe - Access is denied.
Can't clean tmpdir: C:\workspace\node-test-binary-windows-js-suites\node\test\.tmp.355
Files blocking: [ 'install' ]

C:\workspace\node-test-binary-windows-js-suites\node\test\common\tmpdir.js:136
    throw e;
    ^

Error: ENOTEMPTY: directory not empty, rmdir 'C:\workspace\node-test-binary-windows-js-suites\node\test\.tmp.355'
    at Object.rmdirSync (fs.js:783:3)
    at rmdirSync (C:\workspace\node-test-binary-windows-js-suites\node\test\common\tmpdir.js:86:10)
    at rimrafSync (C:\workspace\node-test-binary-windows-js-suites\node\test\common\tmpdir.js:41:7)
    at process.onexit (C:\workspace\node-test-binary-windows-js-suites\node\test\common\tmpdir.js:121:5)
    at process.emit (events.js:314:22) {
  errno: -4051,
  syscall: 'rmdir',
  code: 'ENOTEMPTY',
  path: 'C:\\workspace\\node-test-binary-windows-js-suites\\node\\test\\.tmp.355'
}

On: https://ci.nodejs.org/computer/test-rackspace-win2008r2_vs2017-x64-4/

Ref: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/50/RUN_SUBSET=1,nodes=win2008r2-COMPILED_BY-vs2017/testReport/junit/(root)/test/parallel_test_module_loading_globalpaths/
@richardlau richardlau added flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform. labels Dec 8, 2019
@bnoordhuis
Copy link
Member

I suspect this is the same issue as #30620. Fix forthcoming.

@bnoordhuis bnoordhuis mentioned this issue Dec 8, 2019
Closed
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Dec 12, 2019
@bnoordhuis
test: work around ENOTEMPTY when cleaning tmp dir
944320a 
Replace the homegrown rimrafsync implementation in test/common with
a call to `fs.rmdirSync(path, { recursive: true })`.

Fixes: nodejs#30620
Fixes: nodejs#30844
@Trott Trott closed this as completed in edf654d Dec 12, 2019
MylesBorins pushed a commit that referenced this issue Dec 13, 2019
@bnoordhuis @MylesBorins
test: work around ENOTEMPTY when cleaning tmp dir
1b534d5 
Replace the homegrown rimrafsync implementation in test/common with
a call to `fs.rmdirSync(path, { recursive: true })`.

Fixes: #30620
Fixes: #30844

PR-URL: #30849
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue Jan 14, 2020
@bnoordhuis @targos
test: work around ENOTEMPTY when cleaning tmp dir
5b78bf2 
Replace the homegrown rimrafsync implementation in test/common with
a call to `fs.rmdirSync(path, { recursive: true })`.

Fixes: #30620
Fixes: #30844

PR-URL: #30849
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this issue Feb 6, 2020
@bnoordhuis @BethGriggs
test: work around ENOTEMPTY when cleaning tmp dir
5fff46a 
Replace the homegrown rimrafsync implementation in test/common with
a call to `fs.rmdirSync(path, { recursive: true })`.

Fixes: #30620
Fixes: #30844

PR-URL: #30849
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@anonrig
Copy link
Member

anonrig commented Sep 6, 2024

Opening this again since it has become flaky again. Ref: https://ci.nodejs.org/job/node-test-commit-osx/60975/#showFailuresLink

@anonrig anonrig reopened this Sep 6, 2024
@richardlau
Copy link
Member

Opening this again since it has become flaky again. Ref: https://ci.nodejs.org/job/node-test-commit-osx/60975/#showFailuresLink

For macOS that is because of ongoing issues with disk space nodejs/build#3887

@StefanStojanovic StefanStojanovic removed the windows Issues and PRs related to the Windows platform. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: work around ENOTEMPTY when cleaning tmp dir bnoordhuis/io.js
5 participants
@joaocgreis @bnoordhuis @anonrig @richardlau @StefanStojanovic