How to get the "Date" set on a response header for HTTP2?

[niftylettuce]

Ref: #28302

[niftylettuce]

I think this is due to HTTP2 vs HTTP1. Can someone help clarify this? For HTTP2: how to get raw headers is my question?

[niftylettuce]

After digging I discovered HTTP1 has a String returned for res._header and HTTP2 has a Boolean returned for res._header

node/lib/internal/http2/compat.js

Lines 430 to 435 in 527b609

	// User land modules such as finalhandler just check truthiness of this
	// but if someone is actually trying to use this for more than that
	// then we simply can't support such use cases
	get _header() {
	return this.headersSent;
	}

.

[ZYSzys]

For HTTP2: how to get raw headers is my question?

So use res.getHeaders() ?

node/lib/internal/http2/compat.js

Lines 554 to 556 in c101251

	getHeaders() {
	return { ...this[kHeaders] };
	}

AFAIK, I think we shouldn't rely on a "private" property that could change in value over time for various reasons.

[niftylettuce]

No, that does not work

…

On December 11, 2019 10:58:33 AM UTC, ZYSzys ***@***.***> wrote: So use `res.getHeaders()` ? https://github.com/nodejs/node/blob/c101251a95cc82142bee4637f8db6cc360a06d82/lib/internal/http2/compat.js#L554-L556 AFAIK, I think we shouldn't rely on a "private" property that could change in value over time for various reasons. -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #30894 (comment)

[niftylettuce]

Could we have someone look at this on the core team? I would gladly donate.

[rexagod]

@niftylettuce I think the commit below should fix this. I'll open a PR soon.

Refer: rexagod@8604411

[niftylettuce]

@addaleax any chance this could get backported to v12 before next weeks release (that also fixes the core Chrome HTTP/2 XHR issue at #33875)? cc @BridgeAR @rexagod @codebytere

Ref: https://www.theregister.com/2020/08/18/nodejs_chromium_patch/