-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diagnostic report on fatal error does not respect settings #31576
Comments
For some reason #29601 is 404 erroring but there is a known issue with fatal errors resulting in the report code not having access to the options as they're currently hung off #29881 was fixing cc @addaleax @gireeshpunathil @nodejs/diagnostics |
#29881 is indeed an attempt to address this. Pinging @shobhitchittora to see where do we stand on this |
I ran across #29601 while searching for existing issue and it 404'ed for me too. I'm happy to try and help on this if needed. |
--report-on-fatalerror was not honored properly, as there was no way to check the value which was stored in the Environment pointer which can be inaccessible under certain fatal error situations. Move the flag out of Environment pointer so that this is doable. Co-authored-by: Shobhit Chittora schittora@paypal.com Fixes: nodejs#31576 Refs: nodejs#29881
--report-on-fatalerror was not honored properly, as there was no way to check the value which was stored in the Environment pointer which can be inaccessible under certain fatal error situations. Move the flag out of Environment pointer so that this is doable. Co-authored-by: Shobhit Chittora schittora@paypal.com PR-URL: #32207 Fixes: #31576 Refs: #29881 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
--report-on-fatalerror was not honored properly, as there was no way to check the value which was stored in the Environment pointer which can be inaccessible under certain fatal error situations. Move the flag out of Environment pointer so that this is doable. Co-authored-by: Shobhit Chittora schittora@paypal.com PR-URL: nodejs#32207 Fixes: nodejs#31576 Refs: nodejs#29881 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
--report-on-fatalerror was not honored properly, as there was no way to check the value which was stored in the Environment pointer which can be inaccessible under certain fatal error situations. Move the flag out of Environment pointer so that this is doable. Co-authored-by: Shobhit Chittora schittora@paypal.com PR-URL: #32207 Fixes: #31576 Refs: #29881 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
While troubleshooting OOM crashes in production, I wanted to get access to the diagnostic report. Because it's a container environment, I need the file to be written to a volume, not the cwd, so that it can be accessed when the container goes away. When specifying a report directory via the command line, such as
--report-directory=/var/node
, it is not respected. The file is always written to the default location, thecwd
of the node process.Upon further inspection, it appears that the report is generated, even if
--report-on-fatalerror
is not specified.I stepped through the C++ code and it looks like
Environment::GetCurrent(isolate)
here is returning a null pointer.Steps to reproduce
reports
sub dir where we'd like the report to be written on fatal error:reports
dir. It's empty:--report-on-fatalerror
arg and re-run. The report will still be generated.The text was updated successfully, but these errors were encountered: