Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks doc missing AsyncHook class #31661

Closed
Trott opened this issue Feb 6, 2020 · 0 comments
Closed

async_hooks doc missing AsyncHook class #31661

Trott opened this issue Feb 6, 2020 · 0 comments
Labels
async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations.

Comments

@Trott
Copy link
Member

Trott commented Feb 6, 2020

  • Version: current master branch (v14.0.0-pre)
  • Platform: n/a
  • Subsystem: doc, async_hooks

The docs talk about AsyncHook and specifies it as the return value for methods, but there is no entry for the class.
@Trott Trott added good first issue Issues that are suitable for first-time contributors. doc Issues and PRs related to the documentations. async_hooks Issues and PRs related to the async hooks subsystem. and removed good first issue Issues that are suitable for first-time contributors. labels Feb 6, 2020
@HarshithaKP HarshithaKP mentioned this issue Feb 19, 2020
Closed
4 tasks
HarshithaKP added a commit to HarshithaKP/node that referenced this issue Feb 21, 2020
@HarshithaKP
doc: add entry for AsyncHook class
8644e06 
fixes: nodejs#31661
MylesBorins pushed a commit that referenced this issue Mar 11, 2020
@HarshithaKP @MylesBorins
doc: add entry for AsyncHook class
3fa57ee 
fixes: #31661

PR-URL: #31865
Fixes: #31661
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Apr 22, 2020
@HarshithaKP @targos
doc: add entry for AsyncHook class
c439d83 
fixes: #31661

PR-URL: #31865
Fixes: #31661
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add entry for AsyncHook class HarshithaKP/node
1 participant
@Trott