test-tls-env-extra-ca-file-load fails to test assertions #32072
Comments
ebickle
added a commit
to ebickle/node
that referenced
this issue
Mar 3, 2020
Fixes broken unit test for the NODE_EXTRA_CA_CERTS environment variable. Unit test was exiting without evaluating any assertions or running any tests. Fixes: nodejs#32072
3 tasks
ebickle
added a commit
to ebickle/node
that referenced
this issue
Mar 5, 2020
Fixes broken unit test for the NODE_EXTRA_CA_CERTS environment variable. Unit test was exiting without evaluating any assertions or running any tests. Fixes: nodejs#32072
BridgeAR
pushed a commit
that referenced
this issue
Mar 17, 2020
Fixes broken unit test for the NODE_EXTRA_CA_CERTS environment variable. Unit test was exiting without evaluating any assertions or running any tests. Fixes: #32072 PR-URL: #32073 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this issue
Mar 24, 2020
Fixes broken unit test for the NODE_EXTRA_CA_CERTS environment variable. Unit test was exiting without evaluating any assertions or running any tests. Fixes: #32072 PR-URL: #32073 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this issue
Apr 22, 2020
Fixes broken unit test for the NODE_EXTRA_CA_CERTS environment variable. Unit test was exiting without evaluating any assertions or running any tests. Fixes: #32072 PR-URL: #32073 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What steps will reproduce the bug?
Bug identified in a code review and cannot be directly reproduced: a unit test silently succeeds without executing it's assertions or running any tests.
The unit test
test-tls-env-extra-ca-file-load.jsattempts to fork two child processes with theNODE_EXTRA_CA_CERTSenvironment variable set and unset. The unit test logic of the parent process and child process are gated inside of aif (process.argv[2] !== 'child')statement.The code blocks for the parent and child processes are swapped. During execution the
childprocess argument is not set and the code falls into the assertion block. TheCHILD_USE_EXTRA_CA_CERTSisn't set toyesorno, causing all assertions to be bypassed and the unit test to exit without doing anything. The process is never forked.How often does it reproduce? Is there a required condition?
Reproduces 100% of the time.
What is the expected behavior?
The unit test should fork two child processes and execute the appropriate assertions.
What do you see instead?
Unit test silently finishes without forking any child processes or running assertions.
The text was updated successfully, but these errors were encountered: