-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assertion failure in ../src/node_worker.cc:647 with 4K worker threads #32319
Labels
worker
Issues and PRs related to Worker support.
Comments
That’s what I would suggest 👍 |
/cc @HarshithaKP |
I will pick it up! |
4 tasks
HarshithaKP
added a commit
to HarshithaKP/node
that referenced
this issue
Mar 21, 2020
with large number of worker threads pthread fails with hard assertion. Instead of hard assertion throw a runtime error. Refs: nodejs#32319
targos
pushed a commit
to targos/node
that referenced
this issue
Apr 25, 2020
With large number of worker threads pthread fails with hard assertion. Instead of hard assertion throw a runtime error. PR-URL: nodejs#32344 Fixes: nodejs#32319 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While debugging #32265 I got this:
the definite root cause is the
pthread_create
failure. Should we capture this and convert into a runtime error? following the precedence of #31621 ?The text was updated successfully, but these errors were encountered: