-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeBSD 10.1: build fails #324
Closed
Comments
/cc @indutny I have 2 FreeBSD boxes from Voxer to hook up to CI but it's going to have to wait post 1.0.0 for now, having the tests pass prior to 1.0.0 would be really nice though, if possible. |
indutny
added a commit
to indutny/io.js
that referenced
this issue
Jan 13, 2015
clang++ on FreeBSD was blaming v8 for using invalid casts from nullptr: reinterpret_cast from 'nullptr_t' to '...' is not allowed Replace casts with NULL, or NULL with 0 where applicable. fix nodejs#324
See https://github.com/iojs/io.js/pull/332/files for a fix. Still has lots of test failures :) |
After lots of fixes:
|
Should be better now. |
Just for posterity: https://codereview.chromium.org/839053004 |
bnoordhuis
pushed a commit
to bnoordhuis/io.js
that referenced
this issue
Jan 18, 2015
clang++ on FreeBSD was blaming v8 for using invalid casts from nullptr: reinterpret_cast from 'nullptr_t' to '...' is not allowed Replace casts with NULL, or NULL with 0 where applicable. Fixes: nodejs#324 PR-URL: nodejs#332 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
brendanashworth
added
build
Issues and PRs related to build files or the CI.
freebsd
Issues and PRs related to the FreeBSD platform.
labels
Sep 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Couldn't find any other open bugs about clang compatibility, but this error probably just affects FreeBSD:
V8 seems to call
g++
instead ofc++
(ratherclang++
) which makes the build fail. If I set CC/CPP/CXX environment flags it at least builds, but fails here:This is FreeBSD builder 10.1-RELEASE amd64, clang 3.4.1.
The text was updated successfully, but these errors were encountered: