-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf_hooks: measure() should allow endMark to be omitted #32647
Comments
I'm working on this |
3 tasks
targos
pushed a commit
that referenced
this issue
Apr 12, 2020
Make `startMark` and `endMark` parameters optional. PR-URL: #32651 Fixes: #32647 Refs: https://www.w3.org/TR/user-timing-2/#measure-method Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this issue
Apr 14, 2020
Make `startMark` and `endMark` parameters optional. PR-URL: #32651 Fixes: #32647 Refs: https://www.w3.org/TR/user-timing-2/#measure-method Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this issue
Apr 22, 2020
Make `startMark` and `endMark` parameters optional. PR-URL: #32651 Fixes: #32647 Refs: https://www.w3.org/TR/user-timing-2/#measure-method Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
Always. No condition.
What is the expected behavior?
Undefined is returned.
What do you see instead?
Additional information
Throwing an exception when an endMark parameter is is not passed to
measure()
is documented behavior in Node.js, but W3C User Timing Level 2 version 20190226 says it should default to a value ofperformance.now()
if left undefined.Node's documentation also states "This is the same Performance API as implemented in modern Web browsers," but in this case the behavior is different, because
measure()
does not throw an exception in this circumstance in evergreen web browsers.The text was updated successfully, but these errors were encountered: