Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-debug-signal-cluster fails on centos7 #340

Closed
rvagg opened this issue Jan 13, 2015 · 5 comments · May be fixed by aliscco/alisco-node#198
Closed

test-debug-signal-cluster fails on centos7 #340

rvagg opened this issue Jan 13, 2015 · 5 comments · May be fixed by aliscco/alisco-node#198
Labels
test Issues and PRs related to the tests.

Comments

@rvagg
Copy link
Member

rvagg commented Jan 13, 2015

I think this is intermittent but I've seen it a couple of times already in the same way, only on CentOS 7 (i.e. EL7), e.g. https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/nodes=iojs-centos7-64/71/console

=== release test-debug-signal-cluster ===
Path: parallel/test-debug-signal-cluster
> all workers are running
> Starting debugger agent.
> Debugger listening on port 12343
> Starting debugger agent.
> Debugger listening on port 12345
got pids [12731,12737,12743]

assert.js:100
  throw new assert.AssertionError({
        ^
AssertionError: 4 == 6
    at assertOutputLines (/home/iojs/build/workspace/iojs+any-pr+multi/nodes/iojs-centos7-64/test/parallel/test-debug-signal-cluster.js:80:10)
    at onNoMoreLines [as _onTimeout] (/home/iojs/build/workspace/iojs+any-pr+multi/nodes/iojs-centos7-64/test/parallel/test-debug-signal-cluster.js:48:3)
    at Timer.listOnTimeout (timers.js:90:15)
Command: out/Release/iojs /home/iojs/build/workspace/iojs+any-pr+multi/nodes/iojs-centos7-64/test/parallel/test-debug-signal-cluster.js
@bnoordhuis
Copy link
Member

I've been looking at this test for some time now. The problem is that the feature it tests is inherently timing sensitive (sending signals to start the debugger) but I'm not quite ready to delete it outright. Will keep you posted.

@piscisaureus
Copy link
Contributor

nodejs/node-v0.x-archive@58fcc65
nodejs/node-v0.x-archive@e9df9a0

Both seem good to land to me.

@rvagg
Copy link
Member Author

rvagg commented Jan 17, 2015

👍

bnoordhuis pushed a commit to bnoordhuis/io.js that referenced this issue Jan 19, 2015
Previously if a worker's state machine had already transitioned into the
'listening' state when it received the message enabling the debugger,
the worker would never enable its debugger.

Change the logic to allow the 'listening' as a valid state for enabling
the debugger.

Fixes: nodejs/node-v0.x-archive#6440
Original-PR-URL: nodejs/node-v0.x-archive#9037
Signed-off-by: Julien Gilli <julien.gilli@joyent.com>

Fixes: nodejs#340
PR-URL: nodejs#501
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Bert Belder <bertbelder@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@brendanashworth brendanashworth added the test Issues and PRs related to the tests. label Feb 12, 2015
@Fishrock123
Copy link
Contributor

Do we still need those two commits? I haven't seen a red centos CI anywhere recently..

@bnoordhuis
Copy link
Member

This may have been fixed by 4dd22b9 or 11c1bae (although the second commit predates this issue by a day.) I'll close the issue and reopen if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants