-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-debug-signal-cluster fails on centos7 #340
Comments
I've been looking at this test for some time now. The problem is that the feature it tests is inherently timing sensitive (sending signals to start the debugger) but I'm not quite ready to delete it outright. Will keep you posted. |
nodejs/node-v0.x-archive@58fcc65 Both seem good to land to me. |
👍 |
Previously if a worker's state machine had already transitioned into the 'listening' state when it received the message enabling the debugger, the worker would never enable its debugger. Change the logic to allow the 'listening' as a valid state for enabling the debugger. Fixes: nodejs/node-v0.x-archive#6440 Original-PR-URL: nodejs/node-v0.x-archive#9037 Signed-off-by: Julien Gilli <julien.gilli@joyent.com> Fixes: nodejs#340 PR-URL: nodejs#501 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Bert Belder <bertbelder@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Do we still need those two commits? I haven't seen a red centos CI anywhere recently.. |
I think this is intermittent but I've seen it a couple of times already in the same way, only on CentOS 7 (i.e. EL7), e.g. https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/nodes=iojs-centos7-64/71/console
The text was updated successfully, but these errors were encountered: