Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc Document that IBM i does not support API fs.watch() #34607

Closed
dmabupt opened this issue Aug 3, 2020 · 3 comments
Closed

doc Document that IBM i does not support API fs.watch() #34607

dmabupt opened this issue Aug 3, 2020 · 3 comments

Comments

@dmabupt
Copy link
Contributor

dmabupt commented Aug 3, 2020

IBM i does not support the API fs.watch() -- https://github.com/nodejs/node/pull/30819/files#diff-f57f2ac1ac1926071a04f498c9fe355dR4-R6

Please add the description to the API document -- https://nodejs.org/docs/latest/api/fs.html#fs_availability

For example, On IBM i systems, this feature is not supported. Please use fs.watchFile() instead.
@richardlau
Copy link
Member

@dmabupt Please raise a pull request in this repository with the appropriate changes to https://github.com/nodejs/node/blob/master/doc/api/fs.md.

@ThePrez
Copy link
Contributor

ThePrez commented Aug 3, 2020

Related to #29894 (but the end result was not explicit about IBM i)

@ghost
Copy link

ghost commented Aug 3, 2020

@richardlau assign this one to me as well. I'll update the docs shortly

@richardlau richardlau assigned ghost Aug 3, 2020
@ghost ghost mentioned this issue Aug 3, 2020
Closed
2 tasks
@jasnell jasnell closed this as completed in 0dff5bc Aug 7, 2020
addaleax pushed a commit that referenced this issue Aug 8, 2020
@addaleax
doc: update fs.watch() availability for IBM i
dd6bf20 
Add a line that IBM i does not support `fs.watch()`.

Fixes: #34607
Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability

PR-URL: #34611
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this issue Aug 11, 2020
@codebytere
doc: update fs.watch() availability for IBM i
767a5cb 
Add a line that IBM i does not support `fs.watch()`.

Fixes: #34607
Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability

PR-URL: #34611
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this issue Sep 22, 2020
@addaleax
doc: update fs.watch() availability for IBM i
fac6107 
Add a line that IBM i does not support `fs.watch()`.

Fixes: #34607
Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability

PR-URL: #34611
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this issue Sep 22, 2020
@addaleax
doc: update fs.watch() availability for IBM i
3dda55a 
Add a line that IBM i does not support `fs.watch()`.

Fixes: #34607
Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability

PR-URL: #34611
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: update fs.watch() availability for IBM i
3 participants
@richardlau @dmabupt @ThePrez