Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Land #34035 on v14 (stream: simpler Readable async iterator) #34680

Closed
ronag opened this issue Aug 8, 2020 · 4 comments
Closed

Land #34035 on v14 (stream: simpler Readable async iterator) #34680

ronag opened this issue Aug 8, 2020 · 4 comments
Labels
stream Issues and PRs related to the stream subsystem.

Comments

@ronag
Copy link
Member

ronag commented Aug 8, 2020

@nodejs/tsc @mcollina @benjamingr I defensively marked #34035 as semver-major. However, it would be nice to land this on v14 as it might become the basis for future semver-minor changes.
@ronag ronag added stream Issues and PRs related to the stream subsystem. tsc-agenda Issues and PRs to discuss during the meetings of the TSC. labels Aug 8, 2020
@mhdawson mhdawson mentioned this issue Aug 10, 2020
Closed
@mhdawson
Copy link
Member

@ronag would you be able to make the TSC meeting on Thursday to lead the discussion on this since its tagged for the agenda?

@ronag
Copy link
Member Author

ronag commented Aug 11, 2020

@mhdawson: sure

@mhdawson
Copy link
Member

@ronag thanks. Emailed you the info you'll need to join the zoom.

@mhdawson mhdawson mentioned this issue Aug 17, 2020
Closed
@mhdawson mhdawson removed the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Aug 17, 2020
@ronag ronag mentioned this issue Aug 23, 2020
Closed
4 tasks
richardlau pushed a commit that referenced this issue Sep 7, 2020
@ronag @richardlau
stream: save error in state
51a1a91 
Useful for future PR's to resolve situations where e.g. finished()
is invoked on an already errored streams.

PR-URL: #34103
Backport-PR-URL: #34887
Refs: #34680
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this issue Sep 7, 2020
@ronag @richardlau
stream: simpler and faster Readable async iterator
6a296a4 
Reimplement as an async generator instead of a custom
iterator class.

Backport-PR-URL: #34887
PR-URL: #34035
Refs: #34680
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this issue Sep 7, 2020
@ronag @richardlau
stream: save error in state
ffae5f3 
Useful for future PR's to resolve situations where e.g. finished()
is invoked on an already errored streams.

PR-URL: #34103
Backport-PR-URL: #34887
Refs: #34680
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this issue Sep 7, 2020
@ronag @richardlau
stream: simpler and faster Readable async iterator
4bb4007 
Reimplement as an async generator instead of a custom
iterator class.

Backport-PR-URL: #34887
PR-URL: #34035
Refs: #34680
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Oct 15, 2020
@ronag @MylesBorins
stream: multiple stream backports
573410f 
includes:

* stream: simpler and faster Readable async iterator
* stream: don't destroy on async iterator success
* stream: async iterator stop read if destroyed

PR-URL: #34887
Refs: #34035
Refs: #35122
Refs: #35640
Refs: #34680
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos
Copy link
Member

targos commented May 16, 2021

Assuming it landed in 573410f

@targos targos closed this as completed May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@targos @ronag @mhdawson