Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests call python instead of env.PYTHON #34699

Closed
kapouer opened this issue Aug 9, 2020 · 0 comments
Closed

Some tests call python instead of env.PYTHON #34699

kapouer opened this issue Aug 9, 2020 · 0 comments

Comments

@kapouer
Copy link
Contributor

kapouer commented Aug 9, 2020

Source node <= 14.7.0

Sorry that i can't do a PR at the moment, but at least the issue is reported.

--- a/test/parallel/test-child-process-set-blocking.js
+++ b/test/parallel/test-child-process-set-blocking.js
@@ -26,7 +26,8 @@

 const SIZE = 100000;

-const cp = ch.spawn('python', ['-c', `print(${SIZE} * "C")`], {
+const python = process.env.PYTHON || 'python';
+const cp = ch.spawn(python, ['-c', `print(${SIZE} * "C")`], {
   stdio: 'inherit'
 });

--- a/test/pummel/test-child-process-spawn-loop.js
+++ b/test/pummel/test-child-process-spawn-loop.js
@@ -30,7 +30,8 @@
 let finished = false;

 function doSpawn(i) {
-  const child = spawn('python', ['-c', `print ${SIZE} * "C"`]);
+  const python = process.env.PYTHON || 'python';
+  const child = spawn(python, ['-c', `print ${SIZE} * "C"`]);
   let count = 0;

   child.stdout.setEncoding('ascii');
addaleax added a commit to addaleax/node that referenced this issue Aug 9, 2020
Co-authored-by: Jérémy Lal <kapouer@melix.org>
Fixes: nodejs#34699
MylesBorins pushed a commit that referenced this issue Aug 17, 2020
Co-authored-by: Jérémy Lal <kapouer@melix.org>
Fixes: #34699

PR-URL: #34700
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
BethGriggs pushed a commit that referenced this issue Aug 20, 2020
Co-authored-by: Jérémy Lal <kapouer@melix.org>
Fixes: #34699

PR-URL: #34700
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax added a commit that referenced this issue Sep 22, 2020
Co-authored-by: Jérémy Lal <kapouer@melix.org>
Fixes: #34699

PR-URL: #34700
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax added a commit that referenced this issue Sep 22, 2020
Co-authored-by: Jérémy Lal <kapouer@melix.org>
Fixes: #34699

PR-URL: #34700
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant