Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unistr.cpp:1979:13: warning: 'void uprv_UnicodeStringDummy()' defined but not used [-Wunused-function] #35176

Closed
62f opened this issue Sep 13, 2020 · 2 comments

Comments

@62f
Copy link

62f commented Sep 13, 2020

I would like to work on few of these.

Originally posted by @HarshithaKP in #18983 (comment)

bash-5.0# nvm install --latest-npm v14.10.1
Downloading and installing node v14.10.1...
Downloading https://nodejs.org/dist/v14.10.1/node-v14.10.1-linux-x86.tar.xz...
curl: (22) The requested URL returned error: 404

Binary download from https://nodejs.org/dist/v14.10.1/node-v14.10.1-linux-x86.tar.xz failed, trying source.
grep: /root/.nvm/.cache/bin/node-v14.10.1-linux-x86/node-v14.10.1-linux-x86.tar.xz: No such file or directory
Provided file to checksum does not exist.
Binary download failed, trying source.
Local cache found: $NVM_DIR/.cache/src/node-v14.10.1/node-v14.10.1.tar.xz
Computing checksum with sha256sum
Checksums do not match: 'ece5c5cdca866f147eaf24cab5159b4c72437e115cd46d3d528a6e998ff02965' found, '2b5382f99eda3e7bbb4431f9e70475bc379fc8f30301c36b5b8b9b3764ead5b7' expected.
Checksum check failed!
Removing the broken local cache...
Downloading https://nodejs.org/dist/v14.10.1/node-v14.10.1.tar.xz...
############################################################################### 100.0%
Computing checksum with sha256sum
Checksums matched!
$>./configure --prefix=/root/.nvm/versions/node/v14.10.1 <
Node.js configure: Found Python 3.8.5...
INFO: configure completed successfully
make -C out BUILDTYPE=Release V=0
touch /root/.nvm/.cache/src/node-v14.10.1/files/out/Release/obj.target/tools/icu/icu_implementation.stamp
touch /root/.nvm/.cache/src/node-v14.10.1/files/out/Release/obj.target/tools/icu/icu_uconfig.stamp
touch /root/.nvm/.cache/src/node-v14.10.1/files/out/Release/obj.target/tools/icu/icu_uconfig_target.stamp

g++ -o /root/.nvm/.cache/src/node-v14.10.1/files/out/Release/obj.target/icuucx/deps/icu-small/source/common/unistr.o ../deps/icu-small/source/common/unistr.cpp '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D__STDC_FORMAT_MACROS' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DU_COMMON_IMPLEMENTATION=1' '-DU_ATTRIBUTE_DEPRECATED=' '-D_CRT_SECURE_NO_DEPRECATE=' '-DU_STATIC_IMPLEMENTATION=1' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/icu-small/source/common -pthread -Wall -Wextra -Wno-unused-parameter -m32 -Wno-deprecated-declarations -Wno-strict-aliasing -O3 -fno-omit-frame-pointer -fno-exceptions -std=gnu++1y -frtti -MMD -MF /root/.nvm/.cache/src/node-v14.10.1/files/out/Release/.deps//root/.nvm/.cache/src/node-v14.10.1/files/out/Release/obj.target/icuucx/deps/icu-small/source/common/unistr.o.d.raw -I/usr/bin/cc/include/c++/5.3.0: -c
../deps/icu-small/source/common/unistr.cpp:1979:13: warning: 'void uprv_UnicodeStringDummy()' defined but not used [-Wunused-function]
1979 | static void uprv_UnicodeStringDummy(void) {
| ^~~~~~~~~~~~~~~~~~~~~~~

@bnoordhuis
Copy link
Member

Warnings emitted by files in deps/ are not really under our control, except by turning off the relevant warnings flags.

ICU in particular is not -Wall -Wextra clean. I'd love to see it cleaned up but patches should go upstream, not here.

@bnoordhuis
Copy link
Member

Closing per my previous comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants