-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting warnings in console on fresh build #18983
Comments
Hey, thanks for opening the issue. All these warnings are in Node.js direct dependencies (V8, icu-small, openssl) and they'd have to be fixed there and not in Node. The Node deps folder contains other projects Node depends on copied. Maybe document it in the guide? |
You mean in BUILDING.md guide? |
Maybe as a note below the text "Note that the above requires that python resolve to Python 2.6 or 2.7 and not a newer version."? |
We already disable `-Wmissing-field-initializers` on other Unices but not on MacOS. Fixes: nodejs#18983 (partially)
This is only partially addressed by the commit above. Re-opening. |
We already disable `-Wmissing-field-initializers` on other Unices but not on MacOS. PR-URL: nodejs#19046 Fixes: nodejs#18983 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
We already disable `-Wmissing-field-initializers` on other Unices but not on MacOS. PR-URL: nodejs#19046 Fixes: nodejs#18983 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
We already disable `-Wmissing-field-initializers` on other Unices but not on MacOS. PR-URL: #19046 Fixes: #18983 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
fwiw, here is the outstanding set of warnings when I checked the master on a linux x64:
|
I would like to work on few of these. |
Initialise the superclass object in the copy constructor of mapKVStore PR-URL: #31136 Refs: #18983 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Initialise the superclass object in the copy constructor of mapKVStore PR-URL: #31136 Refs: #18983 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Initialise the superclass object in the copy constructor of mapKVStore PR-URL: #31136 Refs: #18983 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Initialise the superclass object in the copy constructor of mapKVStore PR-URL: #31136 Refs: #18983 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
I guess it's fixed? Feel free to (or ask to) reopen if it isn't. |
I get various warnings in console output if I build node from scratch with
./configure && make -j4
.I guess its nothing to worry about but it might be good first contributions?
Here there are:
The text was updated successfully, but these errors were encountered: