build: disable openssl build warnings on macos #19046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already disable `-Wmissing-field-initializers` on other Unices but not on MacOS. Fixes: nodejs#18983 (partially)
nodejs-github-bot
added
the
openssl
cjihrig
approved these changes
Feb 27, 2018
danbev
approved these changes
Feb 28, 2018
evanlucas
approved these changes
Feb 28, 2018
jasnell
approved these changes
Feb 28, 2018
BridgeAR
approved these changes
Mar 1, 2018
BridgeAR
added
the
author ready
JungMinu
approved these changes
Mar 2, 2018
|
CI: https://ci.nodejs.org/job/node-test-pull-request/13480/ (will land once OS X compiles) |
|
Landed in cb94bf0 |
apapirovski
pushed a commit
that referenced
this pull request
Mar 4, 2018
We already disable `-Wmissing-field-initializers` on other Unices but not on MacOS. PR-URL: #19046 Fixes: #18983 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Mar 5, 2018
We already disable `-Wmissing-field-initializers` on other Unices but not on MacOS. PR-URL: nodejs#19046 Fixes: nodejs#18983 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
We already disable `-Wmissing-field-initializers` on other Unices but not on MacOS. PR-URL: nodejs#19046 Fixes: nodejs#18983 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2018
We already disable `-Wmissing-field-initializers` on other Unices but not on MacOS. PR-URL: #19046 Fixes: #18983 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already disable
-Wmissing-field-initializerson other Unices butnot on MacOS.
Fixes: #18983 (partially)