Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Github CI for draft PRs with label #35899

Closed
jasnell opened this issue Oct 31, 2020 · 1 comment
Closed

Disable Github CI for draft PRs with label #35899

jasnell opened this issue Oct 31, 2020 · 1 comment

Comments

@jasnell
Copy link
Member

jasnell commented Oct 31, 2020

@nodejs/build @nodejs/github-bot ... It would be helpful if the automatic GitHub CI could be disabled for Work-in-progress draft PR's with a "skip-ci" label. This is good for PRs that we want to open early to get awarenes/feedback but that we know aren't ready for testing yet.
@phillipj
Copy link
Member

Would it make sense to not trigger CI on draft PRs in general? Not having to apply a label at all sounds convenient from a distance..

This was referenced Nov 1, 2020
Closed
Closed
@targos targos closed this as completed in aadb0bd Dec 21, 2020
targos added a commit that referenced this issue Dec 21, 2020
@targos
build: do not run GitHub actions for draft PRs
82a2626 
PR-URL: #35910
Fixes: #35899
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jasnell @phillipj