Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It should be impossible to construct an AbortSignal manually #36064

Closed
benjamingr opened this issue Nov 10, 2020 · 3 comments
Closed

It should be impossible to construct an AbortSignal manually #36064

benjamingr opened this issue Nov 10, 2020 · 3 comments
Labels
eventtarget Issues and PRs related to the EventTarget implementation. good first issue Issues that are suitable for first-time contributors.

Comments

@benjamingr
Copy link
Member

In AbortController/AbortSignal it is possible to construct an AbortSignal without a controller (but shouldn't be):

> var c = new AbortController();
> new c.signal.constructor()
AbortSignal { aborted: false }

Correct behavior:

> var c = new AbortController();
new c.signal.constructor()
TypeError: Illegal Constructor

This should be a relatively simple fix but it's a spec compliance issue - so if no new contributor picks this up I'll fix this sometime next week :]
@benjamingr benjamingr added good first issue Issues that are suitable for first-time contributors. eventtarget Issues and PRs related to the EventTarget implementation. labels Nov 10, 2020
@dev-script
Copy link
Contributor

@benjamingr , I would like to work on this issue

@RaisinTen RaisinTen mentioned this issue Nov 12, 2020
Closed
3 tasks
RaisinTen added a commit to RaisinTen/node that referenced this issue Nov 14, 2020
@RaisinTen
events: disabled manual construction AbortSignal
ef80268 
Fixes: nodejs#36064
@benjamingr
Copy link
Member Author

Thanks @RaisinTen !

@RaisinTen
Copy link
Contributor

@benjamincburns you're welcome. 🙂

codebytere pushed a commit that referenced this issue Nov 22, 2020
@RaisinTen @codebytere
events: disabled manual construction AbortSignal
1550073 
Fixes: #36064

PR-URL: #36094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit to targos/node that referenced this issue Apr 24, 2021
@RaisinTen @targos
events: disabled manual construction AbortSignal
6ffedb9 
Fixes: nodejs#36064

PR-URL: nodejs#36094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit to targos/node that referenced this issue Apr 26, 2021
@RaisinTen @targos
events: disabled manual construction AbortSignal
25ec596 
Fixes: nodejs#36064

PR-URL: nodejs#36094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit to targos/node that referenced this issue Apr 30, 2021
@RaisinTen @targos
events: disabled manual construction AbortSignal
0131586 
Fixes: nodejs#36064

PR-URL: nodejs#36094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue Apr 30, 2021
@RaisinTen @targos
events: disabled manual construction AbortSignal
64cd54b 
Fixes: #36064

PR-URL: #36094
Backport-PR-URL: #38386
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
eventtarget Issues and PRs related to the EventTarget implementation. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

events: disabled manual construction AbortSignal RaisinTen/node
3 participants
@benjamingr @dev-script @RaisinTen