Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no linter warning for an async function that is not called #36246

Closed
mmomtchev opened this issue Nov 24, 2020 · 1 comment
Closed

There is no linter warning for an async function that is not called #36246

mmomtchev opened this issue Nov 24, 2020 · 1 comment

Comments

@mmomtchev
Copy link
Contributor

There is a linter warning for not thening an async function, but nothing about a function that is never called, allowing for a much more serious problem as this one:

node/test/parallel/test-fs-promises-file-handle-read.js

Line 75 in 767070c

});

  • Version: master
  • Platform: All
  • Subsystem: test
@mmomtchev
Copy link
Contributor Author

Just please do not submit a PR for the unit test, I have a ready-to-merge PR with a new feature in FileHandle that fixes it

@targos targos self-assigned this Nov 24, 2020
@targos targos mentioned this issue Nov 24, 2020
Closed
2 tasks
targos added a commit to targos/node that referenced this issue Dec 6, 2020
@targos
tools: enable no-unused-expressions lint rule
2a0e98e 
Fixes: nodejs#36246
@targos targos closed this as completed in bf31d3c Dec 7, 2020
cjihrig pushed a commit to cjihrig/node that referenced this issue Dec 8, 2020
@targos @cjihrig
tools: enable no-unused-expressions lint rule
6e3da3b 
Fixes: nodejs#36246

PR-URL: nodejs#36248
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this issue Dec 21, 2020
@targos
tools: enable no-unused-expressions lint rule
040b39f 
Fixes: #36246

PR-URL: #36248
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this issue May 16, 2021
@targos
tools: enable no-unused-expressions lint rule
b39e71b 
Fixes: #36246

PR-URL: #36248
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this issue Jun 11, 2021
@targos
tools: enable no-unused-expressions lint rule
226a86c 
Fixes: #36246

PR-URL: #36248
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos removed their assignment Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: enable no-unused-expressions lint rule targos/node
2 participants
@targos @mmomtchev