-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
events.once
creates an error listener that is not removed on abort
.
#36949
Comments
Lxxyx
added a commit
to Lxxyx/node
that referenced
this issue
Jan 16, 2021
Good catch! |
I'll note that it's frustrating that we support the signal option for |
This was referenced Nov 8, 2022
This was referenced Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
Always.
What is the expected behavior?
The
error
listener should be removed, soconsole.log
should print an empty array.What do you see instead?
console.log
prints an array with one listener.Additional information
It seems the wrong listener is being removed in the following line:
node/lib/events.js
Line 739 in eb8422c
The error listener is called
errorListener
, notresolver
.The text was updated successfully, but these errors were encountered: