Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance should have a toJSON method #37623

Closed
targos opened this issue Mar 6, 2021 · 3 comments
Closed

Performance should have a toJSON method #37623

targos opened this issue Mar 6, 2021 · 3 comments
Labels
perf_hooks Issues and PRs related to the implementation of the Performance Timing API.

Comments

@targos
Copy link
Member

targos commented Mar 6, 2021

Reference: https://www.w3.org/TR/hr-time/#tojson-method

There are WPT for it but they are currently written in HTML: https://github.com/web-platform-tests/wpt/blob/79fa4cf76e0d39e3fc1b7ead85e067b0a064b892/hr-time/performance-tojson.html
@targos targos added the perf_hooks Issues and PRs related to the implementation of the Performance Timing API. label Mar 6, 2021
@yashLadha
Copy link
Contributor

Is it still in discussion phase or can it be implemented in the source?

@targos
Copy link
Member Author

targos commented Mar 16, 2021

I think it can be implemented.

@yashLadha
Copy link
Contributor

Cool, let me kickstart the work on this. If no one has already started yet.

yashLadha added a commit to yashLadha/node that referenced this issue Mar 16, 2021
@yashLadha
perf: add toJSON to performance class
ebd19ea 
Added toJSON method to the InternalPerformance class as per the
convention followed in other performance classes and per the spec:
https://www.w3.org/TR/hr-time/#tojson-method

Fixes: nodejs#37623
@yashLadha yashLadha mentioned this issue Mar 16, 2021
Closed
yashLadha added a commit to yashLadha/node that referenced this issue Mar 17, 2021
@yashLadha
perf: add toJSON to performance class
551aa74 
Added toJSON method to the InternalPerformance class as per the
convention followed in other performance classes and per the spec:
https://www.w3.org/TR/hr-time/#tojson-method

Fixes: nodejs#37623
yashLadha added a commit to yashLadha/node that referenced this issue Mar 17, 2021
@yashLadha
perf: add toJSON to performance class
5647f64 
Added toJSON method to the InternalPerformance class as per the
convention followed in other performance classes and per the spec:
https://www.w3.org/TR/hr-time/#tojson-method

Fixes: nodejs#37623
yashLadha added a commit to yashLadha/node that referenced this issue Mar 17, 2021
@yashLadha
perf: add toJSON to performance class
b90d807 
Added toJSON method to the InternalPerformance class as per the
convention followed in other performance classes and per the spec:
https://www.w3.org/TR/hr-time/#tojson-method

Fixes: nodejs#37623
yashLadha added a commit to yashLadha/node that referenced this issue Mar 17, 2021
@yashLadha
perf: add toJSON to performance class
97b523d 
Added toJSON method to the InternalPerformance class as per the
convention followed in other performance classes and per the spec:
https://www.w3.org/TR/hr-time/#tojson-method

Fixes: nodejs#37623
yashLadha added a commit to yashLadha/node that referenced this issue Mar 17, 2021
@yashLadha
perf: add toJSON to performance class
a439e79 
Added toJSON method to the InternalPerformance class as per the
convention followed in other performance classes and per the spec:
https://www.w3.org/TR/hr-time/#tojson-method

Fixes: nodejs#37623
yashLadha added a commit to yashLadha/node that referenced this issue Mar 17, 2021
@yashLadha
perf: add toJSON to performance class
93ca72e 
Added toJSON method to the InternalPerformance class as per the
convention followed in other performance classes and per the spec:
https://www.w3.org/TR/hr-time/#tojson-method

Fixes: nodejs#37623
yashLadha added a commit to yashLadha/node that referenced this issue Mar 23, 2021
@yashLadha
perf: add toJSON to performance class
27a066c 
Added toJSON method to the InternalPerformance class as per the
convention followed in other performance classes and per the spec:
https://www.w3.org/TR/hr-time/#tojson-method

Fixes: nodejs#37623
yashLadha added a commit to yashLadha/node that referenced this issue Mar 23, 2021
@yashLadha
perf: add toJSON to performance class
73e6da2 
Added toJSON method to the InternalPerformance class as per the
convention followed in other performance classes and per the spec:
https://www.w3.org/TR/hr-time/#tojson-method

Fixes: nodejs#37623
yashLadha added a commit to yashLadha/node that referenced this issue Mar 23, 2021
@yashLadha
perf: add toJSON to performance class
6c99cc7 
Added toJSON method to the InternalPerformance class as per the
convention followed in other performance classes and per the spec:
https://www.w3.org/TR/hr-time/#tojson-method

Fixes: nodejs#37623
targos pushed a commit that referenced this issue May 3, 2021
@yashLadha @targos
perf_hooks: add toJSON to performance class
4711f57 
Added toJSON method to the InternalPerformance class as per the
convention followed in other performance classes and per the spec:
https://www.w3.org/TR/hr-time/#tojson-method

Fixes: #37623

PR-URL: #37771
Fixes: #37623
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: add toJSON to performance class yashLadha/node
2 participants
@targos @yashLadha