-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
investigate flaky wpt/test-timers #37672
Comments
🤦🏻 I ran the wrong test... |
It's definitely a timing issue. We get the worker's |
I thought about calling |
I think the main issue is that we have double parallelization with the WPT.
|
Happened again today: https://ci.nodejs.org/job/node-test-commit-osx/39393/nodes=osx1014/console Seems like a good solution would be to remove the parallelization in testcfg.py? |
Change the wpt tests to not run in parallel in our Python test runner. On my local machine, this changes the time needed to run the suite from about 2 seconds to about 5 seconds, but it makes the test suite much more reliable. Fixes: nodejs#37672
Moving test harness from Parallel to Simple resolves most of the failures. negative-settimeout.any.js still needs to be marked flaky. Refs: nodejs#37672
The text was updated successfully, but these errors were encountered: