-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"clearImmediate" results in an abort #37806
Labels
confirmed-bug
Issues with confirmed bugs.
repl
Issues and PRs related to the REPL subsystem.
timers
Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Comments
aduh95
added
repl
Issues and PRs related to the REPL subsystem.
timers
Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
labels
Mar 19, 2021
It seems to be REPL only, the process doesn't crash when executing a file or using eval. $ node -e 'clearImmediate({hasRef: true, _onImmediate: 100000000000000000})'
internal/timers.js:278
item._idleNext._idlePrev = item._idlePrev;
^
TypeError: Cannot set property '_idlePrev' of undefined
at ImmediateList.remove (internal/timers.js:278:30)
at clearImmediate (timers.js:324:18)
at [eval]:1:1
at Script.runInThisContext (vm.js:133:18)
at Object.runInThisContext (vm.js:310:38)
at internal/process/execution.js:77:19
at [eval]-wrapper:6:22
at evalScript (internal/process/execution.js:76:60)
at internal/main/eval_string.js:23:3 I'm able to reproduce the crash on master branch when executing the given instruction on REPL. |
Linkgoron
added a commit
to Linkgoron/node
that referenced
this issue
Mar 19, 2021
Fix errors that are caused by invoking clearImmediate with arbitrary objects. fixes: nodejs#37806
Linkgoron
added a commit
to Linkgoron/node
that referenced
this issue
Mar 20, 2021
Fix errors that are caused by invoking clearImmediate with arbitrary objects. fixes: nodejs#37806
ruyadorno
pushed a commit
that referenced
this issue
Mar 29, 2021
Fix errors that are caused by invoking clearImmediate with arbitrary objects. fixes: #37806 PR-URL: #37824 Fixes: #37806 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
ruyadorno
pushed a commit
that referenced
this issue
Mar 30, 2021
Fix errors that are caused by invoking clearImmediate with arbitrary objects. fixes: #37806 PR-URL: #37824 Fixes: #37806 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos
pushed a commit
that referenced
this issue
May 1, 2021
Fix errors that are caused by invoking clearImmediate with arbitrary objects. fixes: #37806 PR-URL: #37824 Fixes: #37806 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
confirmed-bug
Issues with confirmed bugs.
repl
Issues and PRs related to the REPL subsystem.
timers
Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
What steps will reproduce the bug?
Setup a node instance,
and run the following javascript code.
Then an abort occurs.
How often does it reproduce? Is there a required condition?
This abort can always be triggered following the steps above.
What is the expected behavior?
If any error occurs, an exception or other similar error-reporting stuff should be thrown. There is no reason to abort the whole node process.
What do you see instead?
Additional information
The text was updated successfully, but these errors were encountered: