Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate flaky test-fs-read-optional-params #37946

Closed
Trott opened this issue Mar 27, 2021 · 0 comments
Closed

investigate flaky test-fs-read-optional-params #37946

Trott opened this issue Mar 27, 2021 · 0 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system. windows Issues and PRs related to the Windows platform.

Comments

@Trott
Copy link
Member

Trott commented Mar 27, 2021

  • Test: test-fs-read-optional-params
  • Platform: win2012r2-COMPILED_BY-vs2019-x86
  • Console Output:
00:28:05 not ok 211 parallel/test-fs-read-optional-params
00:28:05   ---
00:28:05   duration_ms: 0.173
00:28:05   severity: fail
00:28:05   exitcode: 1
00:28:05   stack: |-
00:28:05     node:assert:122
00:28:05       throw new AssertionError(obj);
00:28:05       ^
00:28:05     
00:28:05     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
00:28:05     
00:28:05     0 !== 4
00:28:05     
00:28:05         at C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-fs-read-optional-params.js:22:10
00:28:05         at C:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:388:15
00:28:05         at FSReqCallback.wrapper [as oncomplete] (node:fs:572:5) {
00:28:05       generatedMessage: true,
00:28:05       code: 'ERR_ASSERTION',
00:28:05       actual: 0,
00:28:05       expected: 4,
00:28:05       operator: 'strictEqual'
00:28:05     }
00:28:05   ...
@Trott Trott added fs Issues and PRs related to the fs subsystem / file system. windows Issues and PRs related to the Windows platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Mar 27, 2021
lpinca added a commit to lpinca/node that referenced this issue Mar 30, 2021
@lpinca
test: deflake test-fs-read-optional-params
1adfe36 
If `fs.read()` is called without specifying the `position` option, data
will be read from the current file position. There is another concurrent
`fs.read()` call before the test for no options object which might
invalidate the test expectations.

Run the test for no options object first.

Fixes: nodejs#37946
@lpinca lpinca mentioned this issue Mar 30, 2021
Closed
@lpinca lpinca closed this as completed in fae0320 Apr 3, 2021
MylesBorins pushed a commit that referenced this issue Apr 4, 2021
@lpinca @MylesBorins
test: deflake test-fs-read-optional-params
0d54889 
If `fs.read()` is called without specifying the `position` option, data
will be read from the current file position. There is another concurrent
`fs.read()` call before the test for no options object which might
invalidate the test expectations.

Run the test for no options object first.

PR-URL: #37991
Fixes: #37946
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 5, 2021
@lpinca @MylesBorins
test: deflake test-fs-read-optional-params
0db1a1e 
If `fs.read()` is called without specifying the `position` option, data
will be read from the current file position. There is another concurrent
`fs.read()` call before the test for no options object which might
invalidate the test expectations.

Run the test for no options object first.

PR-URL: #37991
Fixes: #37946
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this issue May 1, 2021
@lpinca @targos
test: deflake test-fs-read-optional-params
d6346e1 
If `fs.read()` is called without specifying the `position` option, data
will be read from the current file position. There is another concurrent
`fs.read()` call before the test for no options object which might
invalidate the test expectations.

Run the test for no options object first.

PR-URL: #37991
Fixes: #37946
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: deflake test-fs-read-optional-params lpinca/node
1 participant
@Trott