Skip to content

tlsServer.setTicketKeys results in an abort #38305

@zyscoder

Description

@zyscoder

What steps will reproduce the bug?

Setup a node instance,

» node

and run the following javascript code.

tls = require('tls');tlsServer = new tls.Server();
tlsServer.setTicketKeys(1);

Then the node instance occurs an abort.

How often does it reproduce? Is there a required condition?

This abort can always be triggered following the steps above.

What is the expected behavior?

If any error occurs, an exception or other similar error-reporting stuff should be thrown. There is no reason to abort the whole node process.

What do you see instead?

» node
Welcome to Node.js v16.0.0-pre.
Type ".help" for more information.
> tls = require('tls');tlsServer = new tls.Server();
Server {
...
}
> tlsServer.setTicketKeys(1);
/home/zys/Toolchains/node/node[24181]: ../src/crypto/crypto_context.cc:1059:static void node::crypto::SecureContext::SetTicketKeys(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[0]->IsArrayBufferView()' failed.
 1: 0x56281bfeaaf4 node::Abort() [/home/zys/Toolchains/node/node]
 2: 0x56281bfeab88  [/home/zys/Toolchains/node/node]
 3: 0x56281c15a1ec node::crypto::SecureContext::SetTicketKeys(v8::FunctionCallbackInfo<v8::Value> const&) [/home/zys/Toolchains/node/node]
 4: 0x56281c269167 v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) [/home/zys/Toolchains/node/node]
 5: 0x56281c269f10  [/home/zys/Toolchains/node/node]
 6: 0x56281c26a507  [/home/zys/Toolchains/node/node]
 7: 0x56281c26a79a v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/home/zys/Toolchains/node/node]
 8: 0x56281cc08259  [/home/zys/Toolchains/node/node]
[1]    24181 abort (core dumped)  /home/zys/Toolchains/node/node                                                                                                                                                                                               

Additional information

Metadata

Metadata

Assignees

No one assigned

    Labels

    confirmed-bugIssues with confirmed bugs.tlsIssues and PRs related to the tls subsystem.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions