-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash in typescript using nodejs 16 on ppcle #38521
Comments
/cc @nodejs/platform-ppc |
@miladfarca are there some options you could recommend to disable V8 optimizations to see if it might be related to code being generated? |
will look into the details on why it is segfaulting on ppc. |
I can confirm that |
@Flarna Thanks for confirming. Would you also be able to use the https://nodejs.org/download/nightly/v16.0.0-nightly202102126ea9af9906/ PPC file will be: https://nodejs.org/download/nightly/v16.0.0-nightly202102126ea9af9906/node-v16.0.0-nightly202102126ea9af9906-linux-ppc64le.tar.gz |
@miladfarca This version looks good. Tried also the next newer version v16.0.0-nightly2021021388d9268d08 => this one shows the problem |
can confirm segfault while building qtwebengine/chromium typescript parts on ppc64le with 16.1.0 |
I can't reproduce with debug build of node (with #38571 applied) |
ok I've tried building with
so far here's the backtrace for
|
I found the issue. It was caused by trampoline pool emission during deopt exit table generation. Deoptimizer expects deopt exits to be continuous. However, trampoline pool breaks this underlining assumption. I will submit a CL to fix this soon. |
CL landed on master and waiting for approval to backport https://bugs.chromium.org/p/v8/issues/detail?id=11764, https://chromium-review.googlesource.com/c/v8/v8/+/2886159, https://chromium-review.googlesource.com/c/v8/v8/+/2888088 |
thanks, confirm it builds chromium/qtwebengine typescript fine now, I've backported patch to 16.1.0 in gentoo: https://bugs.gentoo.org/785751 |
Should be fixed in v16.4.0 |
What steps will reproduce the bug?
building a project (unfortunately closed source) using typescript 4.2.4
Update: Seems to happen with other projects, e.g. building typescript itself
How often does it reproduce? Is there a required condition?
always, no special condition besides using PPCLE (no problem on windows, linux x86, linux arm).
What is the expected behavior?
building works also on PPCLE
What do you see instead?
Additional information
If I attach the debugger problem is gone.
If I add
typeof(node.slice)
(which should be a not in my opinion) just before the line causing theTypeError
it no longer occurs but a similarTypeError
happens at another place.If I add also
typeof()
checks at the next two such locations I finally end up in a segmentation fault with a quite small callstack:The text was updated successfully, but these errors were encountered: