Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: skip permanent failures #867

Merged
merged 1 commit into from
Jun 14, 2021
Merged

lookup: skip permanent failures #867

merged 1 commit into from
Jun 14, 2021

Conversation

targos
Copy link
Member

@targos targos commented Jun 14, 2021

PPC segfaults all seem related to the TypeScript compiler.

  • use HEAD for "nan" (test fixes not in a release)
  • use HEAD for "yargs" (lint fixes not in a release)
  • commander errors on AIX and segfaults on PPC
  • cheerio times out on AIX
  • npm errors on AIX
  • socket.io fails in a V8 CHECK on AIX and segfaults on PPC
  • esprima fails on AIX and segfault on PPC
  • path-to-regexp segfaults on PPC
  • ws fails in a V8 CHECK on PPC
  • glob fails everywhere, including their own CI on Travis
  • jest fails everywhere because MongoDB cannot start
  • debug fails everywhere, including their own CI on Travis

@targos
Copy link
Member Author

targos commented Jun 14, 2021

@codecov-commenter

This comment has been minimized.

@targos
Copy link
Member Author

targos commented Jun 14, 2021

@nodejs/platform-aix @nodejs/platform-ppc FYI

@SimenB
Copy link
Member

SimenB commented Jun 14, 2021

jest fails everywhere because MongoDB cannot start

we somewhat recently bumped the version of mongo we install. Can you link to a build failure?

@targos
Copy link
Member Author

targos commented Jun 14, 2021

jest fails everywhere because MongoDB cannot start

we somewhat recently bumped the version of mongo we install. Can you link to a build failure?

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2701/nodes=fedora-latest-x64/testReport/junit/(root)/citgm/jest_v27_0_4/

@SimenB
Copy link
Member

SimenB commented Jun 14, 2021

I vote for a rm -rf examples... I'll add a script for that and update the script here

@richardlau
Copy link
Member

PPC segfaults all seem related to the TypeScript compiler.

Probably nodejs/node#38521. That references https://chromium-review.googlesource.com/c/v8/v8/+/2881918 which was backported to V8 9.1 in https://chromium-review.googlesource.com/c/v8/v8/+/2886159 which I think was included with nodejs/node#38273 / nodejs/node#38991 -- were these CI runs pre-V8 9.1?

@targos
Copy link
Member Author

targos commented Jun 14, 2021

Yes, the CI run was on v16.3.0. I don't like running CITGM on the staging branch because some modules fail because of the prerelease version number.

@targos targos closed this Jun 14, 2021
@targos targos deleted the lookup-skips branch June 14, 2021 13:15
@targos targos restored the lookup-skips branch June 14, 2021 13:15
@targos targos reopened this Jun 14, 2021
@richardlau
Copy link
Member

Yes, the CI run was on v16.3.0. I don't like running CITGM on the staging branch because some modules fail because of the prerelease version number.

Fair enough. I think I'd prefer not to skip the PPC crashes though so that we can verify they've been fixed by the V8 update when the next 16 release goes out.

@targos
Copy link
Member Author

targos commented Jun 14, 2021

Yes, the CI run was on v16.3.0. I don't like running CITGM on the staging branch because some modules fail because of the prerelease version number.

Fair enough. I think I'd prefer not to skip the PPC crashes though so that we can verify they've been fixed by the V8 update when the next 16 release goes out.

I removed all PPC skips (and Jest)

@richardlau
Copy link
Member

Yes, the CI run was on v16.3.0. I don't like running CITGM on the staging branch because some modules fail because of the prerelease version number.

Fair enough. I think I'd prefer not to skip the PPC crashes though so that we can verify they've been fixed by the V8 update when the next 16 release goes out.

I removed all PPC skips (and Jest)

Please could you remove the AIX skips due to crashes/failing DCHECKs as well (believed to be the same issue)?

- use HEAD for "nan" (test fixes not in a release)
- use HEAD for "yargs" (lint fixes not in a release)
- commander errors on AIX
- cheerio times out on AIX
- npm errors on AIX
- glob fails everywhere, including their own CI on Travis
- debug fails everywhere, including their own CI on Travis
@targos
Copy link
Member Author

targos commented Jun 14, 2021

Yes, the CI run was on v16.3.0. I don't like running CITGM on the staging branch because some modules fail because of the prerelease version number.

Fair enough. I think I'd prefer not to skip the PPC crashes though so that we can verify they've been fixed by the V8 update when the next 16 release goes out.

I removed all PPC skips (and Jest)

Please could you remove the AIX skips due to crashes/failing DCHECKs as well (believed to be the same issue)?

Done

@targos targos merged commit 8bad32f into nodejs:main Jun 14, 2021
@targos targos deleted the lookup-skips branch June 14, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants