-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lookup: skip permanent failures #867
Conversation
This comment has been minimized.
This comment has been minimized.
@nodejs/platform-aix @nodejs/platform-ppc FYI |
we somewhat recently bumped the version of mongo we install. Can you link to a build failure? |
|
I vote for a |
Probably nodejs/node#38521. That references https://chromium-review.googlesource.com/c/v8/v8/+/2881918 which was backported to V8 9.1 in https://chromium-review.googlesource.com/c/v8/v8/+/2886159 which I think was included with nodejs/node#38273 / nodejs/node#38991 -- were these CI runs pre-V8 9.1? |
Yes, the CI run was on v16.3.0. I don't like running CITGM on the staging branch because some modules fail because of the prerelease version number. |
Fair enough. I think I'd prefer not to skip the PPC crashes though so that we can verify they've been fixed by the V8 update when the next 16 release goes out. |
I removed all PPC skips (and Jest) |
Please could you remove the AIX skips due to crashes/failing DCHECKs as well (believed to be the same issue)? |
- use HEAD for "nan" (test fixes not in a release) - use HEAD for "yargs" (lint fixes not in a release) - commander errors on AIX - cheerio times out on AIX - npm errors on AIX - glob fails everywhere, including their own CI on Travis - debug fails everywhere, including their own CI on Travis
Done |
PPC segfaults all seem related to the TypeScript compiler.