Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: include missing pipe info in diagnostic report #38625

Closed
mscdex opened this issue May 10, 2021 · 0 comments
Closed

Feature Request: include missing pipe info in diagnostic report #38625

mscdex opened this issue May 10, 2021 · 0 comments
Labels
feature request Issues that request new features to be added to Node.js. report Issues and PRs related to process.report.

Comments

@mscdex
Copy link
Contributor

mscdex commented May 10, 2021 •
edited
Loading

Currently in node diagnostic reports TCP and UDP sockets include the local and remote endpoints (using uv_*_getsockname() and uv_*_getpeername() respectively), however pipes/UNIX sockets do not. I believe it should be possible to provide these same values for pipes/UNIX sockets using uv_pipe_getsockname() and uv_pipe_getpeername().
@mscdex mscdex added feature request Issues that request new features to be added to Node.js. report Issues and PRs related to process.report. labels May 10, 2021
@mscdex mscdex changed the title Feature Request: include missing pipe info in process report Feature Request: include missing pipe info in diagnostic report May 10, 2021
@legendecas legendecas mentioned this issue May 11, 2021
Closed
danielleadams pushed a commit that referenced this issue May 31, 2021
@legendecas @danielleadams
src: write named pipe info in diagnostic report
61c95f0 
Writes pipe handles with `uv_pipe_getsockname()`
and `uv_pipe_getpeername()`.

PR-URL: #38637
Fixes: #38625
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
richardlau pushed a commit that referenced this issue Jul 16, 2021
@legendecas @richardlau
src: write named pipe info in diagnostic report
d39cf8b 
Writes pipe handles with `uv_pipe_getsockname()`
and `uv_pipe_getpeername()`.

PR-URL: #38637
Fixes: #38625
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
richardlau pushed a commit that referenced this issue Jul 16, 2021
@legendecas @richardlau
src: write named pipe info in diagnostic report
b3a3ea1 
Writes pipe handles with `uv_pipe_getsockname()`
and `uv_pipe_getpeername()`.

PR-URL: #38637
Fixes: #38625
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
richardlau pushed a commit that referenced this issue Jul 19, 2021
@legendecas @richardlau
src: write named pipe info in diagnostic report
f9c7def 
Writes pipe handles with `uv_pipe_getsockname()`
and `uv_pipe_getpeername()`.

PR-URL: #38637
Fixes: #38625
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
richardlau pushed a commit that referenced this issue Jul 20, 2021
@legendecas @richardlau
src: write named pipe info in diagnostic report
846a138 
Writes pipe handles with `uv_pipe_getsockname()`
and `uv_pipe_getpeername()`.

PR-URL: #38637
Fixes: #38625
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
foxxyz pushed a commit to foxxyz/node that referenced this issue Oct 18, 2021
@legendecas @foxxyz
src: write named pipe info in diagnostic report
0b95ad5 
Writes pipe handles with `uv_pipe_getsockname()`
and `uv_pipe_getpeername()`.

PR-URL: nodejs#38637
Fixes: nodejs#38625
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: write named pipe info in diagnostic report legendecas/node
1 participant
@mscdex