Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making BroadcastChannel global #38803

Closed
hsablonniere opened this issue May 24, 2021 · 3 comments
Closed

Making BroadcastChannel global #38803

hsablonniere opened this issue May 24, 2021 · 3 comments
Labels
feature request Issues that request new features to be added to Node.js. stale

Comments

@hsablonniere
Copy link

Hi wonderful Node.js team!

I was wondering if making BroadcastChannel available as a global variable was considered.

I'm working on a project where I created a class that composes a BroadcastChannel, some kind of layer on top of it. I need this on both client AND server side. Right now, I need a Node.js version with import { BroadcastChannel } from 'worker_threads' and a browser version that can rely on global.

Thanks...
@Ayase-252 Ayase-252 added the feature request Issues that request new features to be added to Node.js. label May 25, 2021
@aduh95
Copy link
Contributor

aduh95 commented May 25, 2021

BroadcastChannel is still documented as experimental, we probably want to wait to have a stable implementation fully compatible with the one exposed by browsers before making it global.
Pinging @jasnell as he is the one who did the initial implementation.

@bnoordhuis bnoordhuis mentioned this issue Feb 14, 2022
Merged
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Feb 15, 2022
@bnoordhuis
test: run webmessaging/broadcastchannel WPT
9153384 
Refs: nodejs#38803
nodejs-github-bot pushed a commit that referenced this issue Feb 17, 2022
@bnoordhuis
test: run webmessaging/broadcastchannel WPT
9caceb2 
Refs: #38803

PR-URL: #41962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
bengl pushed a commit to bengl/node that referenced this issue Feb 21, 2022
@bnoordhuis @bengl
test: run webmessaging/broadcastchannel WPT
602acb2 
Refs: nodejs#38803

PR-URL: nodejs#41962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
bengl pushed a commit to bengl/node that referenced this issue Feb 21, 2022
@bnoordhuis @bengl
test: run webmessaging/broadcastchannel WPT
5d5be6e 
Refs: nodejs#38803

PR-URL: nodejs#41962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
bengl pushed a commit that referenced this issue Feb 21, 2022
@bnoordhuis @bengl
test: run webmessaging/broadcastchannel WPT
b3e863e 
Refs: #38803

PR-URL: #41962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
bengl pushed a commit that referenced this issue Feb 21, 2022
@bnoordhuis @bengl
test: run webmessaging/broadcastchannel WPT
c59dd98 
Refs: #38803

PR-URL: #41962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
bengl pushed a commit that referenced this issue Feb 22, 2022
@bnoordhuis @bengl
test: run webmessaging/broadcastchannel WPT
9825ced 
Refs: #38803

PR-URL: #41962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@github-actions
Copy link
Contributor

There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.

For more information on how the project manages feature requests, please consult the feature request management document.

@github-actions github-actions bot added the stale label Mar 24, 2022
@aduh95
Copy link
Contributor

aduh95 commented Mar 24, 2022

Fixed by ce4d3ad.

@aduh95 aduh95 closed this as completed Mar 24, 2022
@targos targos moved this from Pending Triage to Done in Node.js feature requests Mar 24, 2022
@targos targos moved this to Pending Triage in Node.js feature requests Mar 24, 2022
danielleadams pushed a commit to danielleadams/node that referenced this issue Apr 21, 2022
@bnoordhuis @danielleadams
test: run webmessaging/broadcastchannel WPT
55f7a6d 
Refs: nodejs#38803

PR-URL: nodejs#41962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
@bnoordhuis @danielleadams
test: run webmessaging/broadcastchannel WPT
3e354da 
Refs: #38803

PR-URL: #41962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hsablonniere @Ayase-252 @aduh95