-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The order of .node_repl_history should be reversed #3928
Comments
cc @chrisdickinson? The reason is because that is the order |
I can pick this up if it's identified as an issue that needs a fix @Fishrock123 @Vhin @chrisdickinson. |
Can it even be done in a backwards-compatible way? |
No, I think that would be semver-major. I won't object to seeing if it's reasonable for v6 though. |
I have gotten the code working for this. Working on getting the tests to pass. Could use some help on 'em. Could I open a PR with incomplete code and ask for help there @Fishrock123 & @silverwind ? |
@zeusdeux sure, go ahead. :) |
@Fishrock123 Open here -> #4313 :) |
While I wouldn't oppose the change, this does seem like an implementation detail that should not affect users. I'm going to close this issue. However, if someone feels that is a mistake, by all means, re-open or comment. |
Just use following command: |
Currently, .node_repl_history keeps the newest history at the top of the file, and the oldest at the bottom. This is contrary to essentially every other program that uses a similar history file.
.zsh_history, .bash_history, .python_history, .mysql_history, along with many others, all store the oldest at the top and newest commands at the bottom. Presumably, this is done because you can simply append to the file.
Other than node itself, the number of programs that rely on .node_repl_history having the newest at the top is very small, so it's unlikely this change would be problematic.
The text was updated successfully, but these errors were encountered: