Assertion `(source_it) != (source_.end())' failed while doing make #39408
Comments
|
This is typically for built in module not been found. Edit: just found that one of the re-production steps is |
|
@gireeshpunathil does that help? |
|
@legendecas - thanks for the pointers provided, unfortunately, I did not have time to look at that yet. I will try to squeeze in sometime this week. Meanwhile, does it help if I recreate this in a docker image and pass it to you for your inspection? |
|
@legendecas - this was super-quick and super-useful!!! Cannot find native builtin. "internal/per_context/primordials" 1: 0x564f109d3ee4 node::Abort() this is what I get with your patch. How do I fix this now? Any idea? |
|
That sounds like a problem on the Can you |
|
In one system: gireesh@s1:~/node$ grep "primordials" config.gypi
'lib/internal/per_context/primordials.js',
gireesh@s1:~/node$ ./configure
Node.js configure: Found Python 3.8.10...
INFO: configure completed successfully
gireesh@s1:~/node$ grep "primordials" config.gypi
gireesh@s1:~/node$ In another system: root@828e127b5089:/node# grep "primordials" config.gypi
'lib/internal/per_context/primordials.js',
root@828e127b5089:/node# ./configure
Node.js configure: Found Python 3.8.10...
INFO: configure completed successfully
root@828e127b5089:/node# grep "primordials" config.gypi
'lib/internal/per_context/primordials.js',
root@828e127b5089:/node# I am confused. :) |
|
@gireeshpunathil if the first output is the problem behaving one, can you try this command |
|
@legendecas - here it is: ['lib/assert/strict.js', 'lib/dns/promises.js', 'lib/fs/promises.js', 'lib/internal/abort_controller.js', 'lib/internal/assert.js', 'lib/internal/async_hooks.js', 'lib/internal/blob.js', 'lib/internal/blocklist.js', 'lib/internal/buffer.js', 'lib/internal/child_process.js', 'lib/internal/cli_table.js', 'lib/internal/constants.js', 'lib/internal/dgram.js', 'lib/internal/dtrace.js', 'lib/internal/encoding.js', 'lib/internal/error_serdes.js', 'lib/internal/errors.js', 'lib/internal/event_target.js', 'lib/internal/fixed_queue.js', 'lib/internal/freelist.js', 'lib/internal/freeze_intrinsics.js', 'lib/internal/heap_utils.js', 'lib/internal/histogram.js', 'lib/internal/http.js', 'lib/internal/idna.js', 'lib/internal/inspector_async_hook.js', 'lib/internal/js_stream_socket.js', 'lib/internal/linkedlist.js', 'lib/internal/net.js', 'lib/internal/options.js', 'lib/internal/priority_queue.js', 'lib/internal/querystring.js', 'lib/internal/repl.js', 'lib/internal/socket_list.js', 'lib/internal/socketaddress.js', 'lib/internal/stream_base_commons.js', 'lib/internal/timers.js', 'lib/internal/trace_events_async_hooks.js', 'lib/internal/tty.js', 'lib/internal/url.js', 'lib/internal/util.js', 'lib/internal/v8_prof_polyfill.js', 'lib/internal/v8_prof_processor.js', 'lib/internal/validators.js', 'lib/internal/watchdog.js', 'lib/internal/worker.js', 'lib/path/posix.js', 'lib/path/win32.js', 'lib/stream/promises.js', 'lib/stream/web.js', 'lib/timers/promises.js', 'lib/util/types.js'] |
|
@legendecas - I think at this point I should mention this - now that you are bringing python into the issue: diff --git a/tools/utils.py b/tools/utils.py
index 9d53bd56bd..35a0bd22a0 100644
--- a/tools/utils.py
+++ b/tools/utils.py
@@ -109,7 +109,7 @@ def IsWindows():
def SearchFiles(dir, ext):
- list = glob.glob(dir+ '/**/*.' + ext, recursive=True)
+ list = glob.glob(dir+ '/**/*.' + ext)
if sys.platform == 'win32':
list = [ x.replace('\\', '/')for x in list]
return listI had to make this change in utils.py, as without that it was giving an error that the the function does not take the second parameter. Do you think this could have any effect on the failure that we are seeing? |
|
@gireeshpunathil I believe that option is exactly the issue here. Can you share the error when the function takes the second parameter? |
|
|
This should have been fixed by #39293 |
|
I was wondering if the |
|
Build step of node_js2c: https://github.com/nodejs/node/blob/master/node.gyp#L820 So the problem here is that #39293 is hoisting the result of search files. However, |
|
@legendecas - I applied this patch (#39465) and could resolve the issue, thanks! |
To help core contributors identify which file is missing from the build. PR-URL: #39460 Refs: #39408 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
To help core contributors identify which file is missing from the build. PR-URL: #39460 Refs: #39408 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
@gireeshpunathil As the comment #39465 (comment) suggests, can you check out the content of |
|
cat config.mk @legendecas - here is the dump of |
|
@gireeshpunathil it seems that python2 is not even in your path, so |
|
@legendecas - no, I don't have python2 in my path, as I never installed one. Am I supposed to? The build instructions at https://github.com/nodejs/node/blob/master/BUILDING.md#note-about-python do not specify to do so? |
|
@gireeshpunathil No, you don't have to install python2. I'm just wondering where did the python2 pop out during the build and how do we override the |
To help core contributors identify which file is missing from the build. PR-URL: #39460 Refs: #39408 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
To help core contributors identify which file is missing from the build. PR-URL: #39460 Refs: #39408 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #39465 Fixes: #39408 Fixes: #39456 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #39465 Fixes: #39408 Fixes: #39456 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
To help core contributors identify which file is missing from the build. PR-URL: #39460 Refs: #39408 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #39465 Fixes: #39408 Fixes: #39456 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Version
master
Platform
Linux 5.4.0-77-generic #86-Ubuntu SMP Thu Jun 17 02:35:03 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Subsystem
build
What steps will reproduce the bug?
$./configure
$make -j4
How often does it reproduce? Is there a required condition?
everytime
What is the expected behavior?
node builds successfully
What do you see instead?
build crashes
Additional information
first time I am building in this system, so suspect something specific to build toolchain versions, resource limit etc. but cannot figure out what.
The text was updated successfully, but these errors were encountered: