Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

takeHeapSnapshot() file write race condition #39555

Closed
bnoordhuis opened this issue Feb 21, 2018 · 1 comment
Closed

takeHeapSnapshot() file write race condition #39555

bnoordhuis opened this issue Feb 21, 2018 · 1 comment

Comments

@bnoordhuis
Copy link
Member 

$ ./out/Release/node inspect -p 0
Debugger listening on ws://127.0.0.1:9229/ef5d9804-6bab-4956-b2da-04b21081fac7
For help see https://nodejs.org/en/docs/inspector
connecting to 127.0.0.1:9229 ...Debugger attached.
debug> takeHeapSnapshot(); takeHeapSnapshot()
Heap snaphost prepared.
Heap snaphost prepared.
Heap snaphost prepared.
Heap snaphost prepared.
Error [ERR_STREAM_WRITE_AFTER_END]: write after end
    at writeAfterEnd (_stream_writable.js:227:12)
    at WriteStream.Writable.write (_stream_writable.js:277:5)
    at Proxy.onChunk (internal/deps/node-inspect/lib/internal/inspect_repl.js:913:20)
    at Proxy.emit (events.js:134:15)
    at Proxy.emit (domain.js:437:20)
    at Client.NodeInspector.handleDebugEvent (internal/deps/node-inspect/lib/_inspect.js:169:22)
    at Client.emit (events.js:129:13)
    at Client.emit (domain.js:437:20)
    at Client._handleChunk (internal/deps/node-inspect/lib/internal/inspect_client.js:216:14)
    at Socket.emit (events.js:129:13)
Writing snapshot: 5341202Error [ERR_STREAM_WRITE_AFTER_END]: write after end
    at writeAfterEnd (_stream_writable.js:227:12)
    at WriteStream.Writable.write (_stream_writable.js:277:5)
    at Proxy.onChunk (internal/deps/node-inspect/lib/internal/inspect_repl.js:913:20)
    at Proxy.emit (events.js:134:15)
    at Proxy.emit (domain.js:437:20)
    at Client.NodeInspector.handleDebugEvent (internal/deps/node-inspect/lib/_inspect.js:169:22)
    at Client.emit (events.js:129:13)
    at Client.emit (domain.js:437:20)
    at Client._handleChunk (internal/deps/node-inspect/lib/internal/inspect_client.js:216:14)
    at Socket.emit (events.js:129:13)
// etc.
@Trott Trott transferred this issue from nodejs/node-inspect Jul 28, 2021
Trott added a commit to Trott/io.js that referenced this issue Jul 28, 2021
@Trott
test: add known issues test for debugger heap snapshot race
97b96b4 
Refs: nodejs#39555
@Trott Trott mentioned this issue Jul 28, 2021
Closed
Trott added a commit to Trott/io.js that referenced this issue Jul 28, 2021
@Trott
test: add known issues test for debugger heap snapshot race
4f04bbe 
Refs: nodejs#39555
Trott added a commit to Trott/io.js that referenced this issue Jul 28, 2021
@Trott
test: add known issues test for debugger heap snapshot race
24c941c 
Refs: nodejs#39555
Trott added a commit to Trott/io.js that referenced this issue Jul 28, 2021
@Trott
test: add known issues test for debugger heap snapshot race
48b60c5 
Refs: nodejs#39555
@gireeshpunathil
Copy link
Member

/cc @nodejs/inspector - knowing which area needs to be synchronized will be a good starting point for someone to start looking into this.

nodejs-github-bot pushed a commit that referenced this issue Aug 1, 2021
@Trott @nodejs-github-bot
test: add known issues test for debugger heap snapshot race
7db86e7 
Refs: #39555

PR-URL: #39557
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Trott added a commit to Trott/io.js that referenced this issue Aug 3, 2021
@Trott
debugger: prevent simultaneous heap snapshots
c24deca 
Fixes: nodejs#39555
@Trott Trott mentioned this issue Aug 3, 2021
Closed
danielleadams pushed a commit that referenced this issue Aug 16, 2021
@Trott @danielleadams
test: add known issues test for debugger heap snapshot race
cff2aea 
Refs: #39555

PR-URL: #39557
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit that referenced this issue Aug 16, 2021
@Trott @danielleadams
debugger: prevent simultaneous heap snapshots
3321b65 
Fixes: #39555

PR-URL: #39638
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this issue Sep 4, 2021
@Trott @targos
debugger: prevent simultaneous heap snapshots
b3352cf 
Fixes: #39555

PR-URL: #39638
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

debugger: prevent simultaneous heap snapshots Trott/io.js
2 participants
@bnoordhuis @gireeshpunathil