-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with newer V8 versions #42375
Comments
I borrow a windows to fix this. But I do hope there is a long term plan for this (accessing windows vm) |
Update:
|
I had a quick look at the windows/arm64 specific issue due to the upgrade. I can see at least two issues (1) Native compilation fails with the latest windows SDK (10.0.220000). Looks like a minor issue. I will try to propose a change to V8 to fix it. But older SDK versions should work (2) Cross-compilation fails for win/arm64. This looks like it due to using pre-compiled headers to build host modules and some conflicts between x64 and arm64 register definitions. I don't understand the code well enough to propose a fix, but looks like disabling pre-compiled header for host toolset might fix it |
Interesting. Thanks for investigating! |
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: #42375 PR-URL: #42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
See #42115 (comment). I'm opening a new issue for visibility.
Staring with V8 version 9.9 (and still with the latest canary, V8 fails to compile on Windows with MSVC (2019 and 2022).
@bnoordhuis tried to help finding a workaround, but it didn't work.
I opened an issue on V8's tracker (v8:12661). It was assigned a low priority which makes sense from their point of view because MSVC is not officially supported by V8.
@gengjiawen requested access to a Windows VM in nodejs/build#2891 but it's not clear if someone is going to give them this access.
I think this is becoming critical for us. V8 updates are blocked because of this issue and we are coming close to the release of v18.0.0.
@nodejs/tsc @nodejs/platform-windows @nodejs/v8-update @nodejs/v8
The text was updated successfully, but these errors were encountered: