Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with newer V8 versions #42375

Closed
targos opened this issue Mar 17, 2022 · 11 comments
Closed

Issues with newer V8 versions #42375

targos opened this issue Mar 17, 2022 · 11 comments
Labels
help wanted Issues that need assistance from volunteers or PRs that need help to proceed. v8 engine Issues and PRs related to the V8 dependency. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. windows Issues and PRs related to the Windows platform.

Comments

@targos
Copy link
Member

targos commented Mar 17, 2022

See #42115 (comment). I'm opening a new issue for visibility.

Staring with V8 version 9.9 (and still with the latest canary, V8 fails to compile on Windows with MSVC (2019 and 2022).

@bnoordhuis tried to help finding a workaround, but it didn't work.

I opened an issue on V8's tracker (v8:12661). It was assigned a low priority which makes sense from their point of view because MSVC is not officially supported by V8.

@gengjiawen requested access to a Windows VM in nodejs/build#2891 but it's not clear if someone is going to give them this access.

I think this is becoming critical for us. V8 updates are blocked because of this issue and we are coming close to the release of v18.0.0.

@nodejs/tsc @nodejs/platform-windows @nodejs/v8-update @nodejs/v8

@targos targos added windows Issues and PRs related to the Windows platform. v8 engine Issues and PRs related to the V8 dependency. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Mar 17, 2022
@targos targos changed the title V8 9.9 fails compile on Windows with MSVC V8 9.9 fails to compile on Windows with MSVC Mar 17, 2022
@targos targos added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Mar 17, 2022
@nodejs nodejs deleted a comment from gjw0813 Mar 17, 2022
@gengjiawen
Copy link
Member

I borrow a windows to fix this. But I do hope there is a long term plan for this (accessing windows vm)

@targos targos changed the title V8 9.9 fails to compile on Windows with MSVC V8 fails to compile on Windows with MSVC Mar 22, 2022
@targos
Copy link
Member Author

targos commented Mar 22, 2022

Update:

@targos targos changed the title V8 fails to compile on Windows with MSVC Issues with newer V8 versions Mar 22, 2022
@niyas-sait
Copy link
Contributor

I had a quick look at the windows/arm64 specific issue due to the upgrade. I can see at least two issues

(1) Native compilation fails with the latest windows SDK (10.0.220000). Looks like a minor issue. I will try to propose a change to V8 to fix it. But older SDK versions should work

(2) Cross-compilation fails for win/arm64. This looks like it due to using pre-compiled headers to build host modules and some conflicts between x64 and arm64 register definitions. I don't understand the code well enough to propose a fix, but looks like disabling pre-compiled header for host toolset might fix it

@targos
Copy link
Member Author

targos commented Mar 30, 2022

This looks like it due to using pre-compiled headers to build host modules and some conflicts between x64 and arm64 register definitions.

Interesting. Thanks for investigating!

@mcollina mcollina added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Mar 30, 2022
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 12, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 13, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 14, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 15, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 16, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 17, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 18, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 19, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 20, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 21, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 22, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 23, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 24, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 25, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 26, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 27, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 28, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 29, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 30, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
…st builds"

This reverts commit 818284b.

Reverted commit is a no longer needed patch for ARM64 cross-compiling.
It was increasing cross-compile time drastically (~3 times longer).

PR-URL: #45432
Refs: #42538
Refs: #42375
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
…st builds"

This reverts commit 818284b.

Reverted commit is a no longer needed patch for ARM64 cross-compiling.
It was increasing cross-compile time drastically (~3 times longer).

PR-URL: #45432
Refs: #42538
Refs: #42375
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Dec 31, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Jan 1, 2023
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Jan 2, 2023
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this issue Jan 2, 2023
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: #42375

PR-URL: #42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Jan 2, 2023
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Jan 3, 2023
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit that referenced this issue Jan 3, 2023
…st builds"

This reverts commit 818284b.

Reverted commit is a no longer needed patch for ARM64 cross-compiling.
It was increasing cross-compile time drastically (~3 times longer).

PR-URL: #45432
Refs: #42538
Refs: #42375
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
danielleadams pushed a commit that referenced this issue Jan 4, 2023
…st builds"

This reverts commit 818284b.

Reverted commit is a no longer needed patch for ARM64 cross-compiling.
It was increasing cross-compile time drastically (~3 times longer).

PR-URL: #45432
Refs: #42538
Refs: #42375
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this issue Jan 4, 2023
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues that need assistance from volunteers or PRs that need help to proceed. v8 engine Issues and PRs related to the V8 dependency. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

4 participants