Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracking issue: MSVC regression for 16.x and 14.x vs2022 #42560

Closed
gengjiawen opened this issue Apr 1, 2022 · 4 comments
Closed

tracking issue: MSVC regression for 16.x and 14.x vs2022 #42560

gengjiawen opened this issue Apr 1, 2022 · 4 comments
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Comments

@gengjiawen
Copy link
Member

gengjiawen commented Apr 1, 2022 •
edited
Loading

I am just wondering if we should open an issue to track/identify this problem?

Sure. I also tried to report the bug to MSVC team yesterday, but report bug entrance only in visual studio on windows which I don't have for now.

I've already reported this bug to MSVC team issue ticket

Originally posted by @euphy-wong in #42299 (comment)

Links: #42200

Hope MS will fix soon.
@gengjiawen gengjiawen changed the title tracking issue: MSVC regression for 16.x and 14.x tracking issue: MSVC regression for 16.x and 14.x vs2022 Apr 1, 2022
@targos targos added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Apr 4, 2022
@gengjiawen gengjiawen mentioned this issue May 14, 2022
Open
@F3n67u
Copy link
Member

F3n67u commented Jun 19, 2022

seems still no progress on the Microsoft side, I add a comment on the Microsoft ticket to try to push the progress of the investigation.

@dennisameling
Copy link
Contributor

dennisameling commented Aug 13, 2022 •
edited
Loading

It looks like the fix has been released by MS in VS 2022 17.3 a few days ago 🎉 I was able to build 16.x (x64) successfully using that VS version locally. The GitHub Actions runners are still on 17.2, but those images are updated weekly, so I wouldn't be surprised if they update to 17.3 in the next two weeks or so.

The issue with building the main branch remains even after this update, but there's a separate issue for that already.

dennisameling added a commit to dennisameling/node that referenced this issue Aug 23, 2022
@dennisameling
build: add windows-2022 to v16.x actions
ba4fd72 
This was reverted in the commit mentioned below due to a
compiler bug. The bug got resolved in MSVC 14.33, which
is part of the GitHub Actions 20220821.1 image for
windows-2022.

Ref: nodejs@79e2ab2
Ref: nodejs#42560
Ref: https://developercommunity.visualstudio.com/t/Failed-to-compile-nodejs-16140-with-la/1682115?space=62&q=nodejs
Ref: https://github.com/actions/runner-images/blob/releases/win22/20220821/images/win/Windows2022-Readme.md
@dennisameling dennisameling mentioned this issue Aug 23, 2022
Closed
@dennisameling
Copy link
Contributor

dennisameling commented Aug 23, 2022 •
edited
Loading

GitHub Actions Runner image version 20220821.1 contains MSVC 14.33 which includes the fix for this bug. Here's a PR to re-enable windows-2022 for 16.x: #44365

14.x doesn't have support in vcbuild.bat to detect VS 2022, so enabling it in CI there won't work. The PR that added support for it even explicitly has the dont-land-on-14.x label on it. 14.x also uses a lower version of gyp (0.7.0) while support for VS2022 was added only in 0.10.0.

@targos
Copy link
Member

targos commented Nov 14, 2022

Can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@targos @gengjiawen @F3n67u @dennisameling