Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce x86 Windows support #42690

Closed
3 tasks
targos opened this issue Apr 11, 2022 · 4 comments
Closed
3 tasks

Reintroduce x86 Windows support #42690

targos opened this issue Apr 11, 2022 · 4 comments
Labels
blocked PRs that are blocked by other issues or PRs. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. windows Issues and PRs related to the Windows platform.

Comments

@targos
Copy link
Member

targos commented Apr 11, 2022 •
edited by richardlau
Loading

Assuming #42666 lands.

This should be feasible as soon as we merge V8 10.2 (or earlier if someone finds a fix).

Commits to revert:
@targos targos added windows Issues and PRs related to the Windows platform. blocked PRs that are blocked by other issues or PRs. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Apr 11, 2022
@richardlau richardlau mentioned this issue Apr 11, 2022
Merged
@targos
Copy link
Member Author

targos commented Apr 14, 2022

#42740 should fix the build (but CI skips it for now)

richardlau added a commit to nodejs/build that referenced this issue Apr 14, 2022
@richardlau
jenkins: run win32 CI on Node.js 19
d19145e 
Run 32-bit Windows CI for Node.js 19 but skip (for now) on Node.js 18.

Introduce a new `gteLt` closure for exclusions between two versions.

Refs: nodejs/node#42690
Refs: nodejs/node#42740 (comment)
Refs: #2921
@richardlau richardlau mentioned this issue Apr 14, 2022
Merged
@richardlau
Copy link
Member

#42740 should fix the build (but CI skips it for now)

I've opened nodejs/build#2927 which should re-enable 32-bit Windows CI once master's version is bumped up to 19 after Node.js 18 is released. We'll continue to skip on Node.js 18 until the V8 backport to it is ready.

richardlau added a commit to nodejs/build that referenced this issue Apr 19, 2022
@richardlau
jenkins: run win32 CI on Node.js 19 (#2927)
5e2ae08 
Run 32-bit Windows CI for Node.js 19 but skip (for now) on Node.js 18.

Introduce a new `gteLt` closure for exclusions between two versions.

Refs: nodejs/node#42690
Refs: nodejs/node#42740 (comment)
Refs: #2921
This was referenced May 25, 2022
Closed
Merged
Merged
@mhdawson
Copy link
Member

@richardlau can we close this out now?

@richardlau
Copy link
Member

Yes, we restored 32-bit Windows binaries for Node.js 18 in Node.js 18.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked PRs that are blocked by other issues or PRs. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@targos @richardlau @mhdawson