Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.\vcbuild on Windows is not aware of default python installation in "c:\program files\..." #42801

Closed
jeffrson opened this issue Apr 20, 2022 · 1 comment · Fixed by #42810
Closed

.\vcbuild on Windows is not aware of default python installation in "c:\program files\..." #42801

jeffrson opened this issue Apr 20, 2022 · 1 comment · Fixed by #42810
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Comments

@jeffrson
Copy link

jeffrson commented Apr 20, 2022 •
edited by VoltrexKeyva
Loading

Version

18.0.0

Platform

Microsoft Windows NT 10.0.19044.0 x64

Subsystem

No response

What steps will reproduce the bug?

Install python 3.10 from python.org with default settings - will install to c:\program files\python10

Run .\vcbuild

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

.\vcbuild will find this installation at first, but fails after that:

Looking for Python
Python found in C:\Program Files\Python310\\python.exe
Der Befehl "C:\Program" ist entweder falsch geschrieben oder
konnte nicht gefunden werden.
Not an executable Python program
Could not find Python.

Additional information

Yes, there are ways around this. Yes, it could be documented in building.md.

Best way would be to make find_python.cmd aware of spaces in python's installation path.
@VoltrexKeyva VoltrexKeyva added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Apr 21, 2022
lpinca added a commit to lpinca/node that referenced this issue Apr 21, 2022
@lpinca
build: improve reliability of find_python.cmd script
4e44222 
The path of Python executable might contain white spaces. Handle this
when the `check-python` function is called.

Fixes: nodejs#42801
@lpinca lpinca mentioned this issue Apr 21, 2022
Merged
lpinca added a commit to lpinca/node that referenced this issue Apr 21, 2022
@lpinca
build: improve reliability of find_python.cmd script
2faf997 
The path of the Python executable might contain white spaces. Handle
this when the `check-python` function is called.

Fixes: nodejs#42801
@takipsizad
Copy link

i kinda doubt since it seems like more of escaping isuse but a valid issue anyway

nodejs-github-bot pushed a commit that referenced this issue Apr 23, 2022
@lpinca
build: improve reliability of find_python.cmd script
e2ff1c3 
The path of the Python executable might contain white spaces. Handle
this when the `check-python` function is called.

Fixes: #42801

PR-URL: #42810
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
xtx1130 pushed a commit to xtx1130/node that referenced this issue Apr 25, 2022
@lpinca @xtx1130
build: improve reliability of find_python.cmd script
a549038 
The path of the Python executable might contain white spaces. Handle
this when the `check-python` function is called.

Fixes: nodejs#42801

PR-URL: nodejs#42810
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Apr 28, 2022
@lpinca @targos
build: improve reliability of find_python.cmd script
f9994e2 
The path of the Python executable might contain white spaces. Handle
this when the `check-python` function is called.

Fixes: #42801

PR-URL: #42810
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol pushed a commit that referenced this issue May 31, 2022
@lpinca @juanarbol
build: improve reliability of find_python.cmd script
c3fc44b 
The path of the Python executable might contain white spaces. Handle
this when the `check-python` function is called.

Fixes: #42801

PR-URL: #42810
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this issue Jun 27, 2022
@lpinca @danielleadams
build: improve reliability of find_python.cmd script
f85c9d7 
The path of the Python executable might contain white spaces. Handle
this when the `check-python` function is called.

Fixes: #42801

PR-URL: #42810
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Jul 12, 2022
@lpinca @targos
build: improve reliability of find_python.cmd script
fa9b765 
The path of the Python executable might contain white spaces. Handle
this when the `check-python` function is called.

Fixes: #42801

PR-URL: #42810
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Jul 31, 2022
@lpinca @targos
build: improve reliability of find_python.cmd script
74bce1c 
The path of the Python executable might contain white spaces. Handle
this when the `check-python` function is called.

Fixes: #42801

PR-URL: #42810
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Oct 10, 2022
@lpinca @guangwong
build: improve reliability of find_python.cmd script
758e073 
The path of the Python executable might contain white spaces. Handle
this when the `check-python` function is called.

Fixes: nodejs/node#42801

PR-URL: nodejs/node#42810
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: improve reliability of find_python.cmd script lpinca/node
3 participants
@jeffrson @takipsizad @VoltrexKeyva