-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash in AfterOpenFileHandle #42829
Labels
confirmed-bug
Issues with confirmed bugs.
fs
Issues and PRs related to the fs subsystem / file system.
Comments
tniessen
added
confirmed-bug
Issues with confirmed bugs.
fs
Issues and PRs related to the fs subsystem / file system.
labels
Apr 22, 2022
Refs: #42701 (comment) |
santigimeno
added a commit
to santigimeno/node
that referenced
this issue
Apr 29, 2022
This is specially prevalent in the case of having in-progress FileHandle operations in a worker thread while the Worker is exiting. Fixes: nodejs#42829
santigimeno
added a commit
to santigimeno/node
that referenced
this issue
May 4, 2022
This is specially prevalent in the case of having in-progress FileHandle operations in a worker thread while the Worker is exiting. Fixes: nodejs#42829
|
santigimeno
added a commit
to santigimeno/node
that referenced
this issue
May 9, 2022
This is specially prevalent in the case of having in-progress FileHandle operations in a worker thread while the Worker is exiting. Fixes: nodejs#42829
aduh95
pushed a commit
to santigimeno/node
that referenced
this issue
Jun 17, 2022
This is specially prevalent in the case of having in-progress FileHandle operations in a worker thread while the Worker is exiting. Fixes: nodejs#42829
santigimeno
added a commit
to santigimeno/node
that referenced
this issue
Jun 17, 2022
This is specially prevalent in the case of having in-progress FileHandle operations in a worker thread while the Worker is exiting. Fixes: nodejs#42829
guangwong
pushed a commit
to noslate-project/node
that referenced
this issue
Oct 10, 2022
This is specially prevalent in the case of having in-progress FileHandle operations in a worker thread while the Worker is exiting. Fixes: nodejs/node#42829 PR-URL: nodejs/node#42910 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
confirmed-bug
Issues with confirmed bugs.
fs
Issues and PRs related to the fs subsystem / file system.
Version
latest (18.0.0)
Platform
Linux
Subsystem
fs (presumably)
What steps will reproduce the bug?
Compile Node.js:
For reference, I am building Node.js as of 3a6b975.
Add WPTs for
wasm/webapi
andwasm/jsapi
:For reference, for me, this has resulted in the following additions to
versions.json
:Create
test/wpt/status/wasm/webapi.json
and mark all tests as failing:If any of these WPTs are not failing, that likely only means that node's compliance with the WPTs improved. In that case, we might not be able to reproduce this bug using these WPTs anymore, but it does not necessarily mean that the bug has been fixed.
Create
test/wpt/test-wasm-webapi.js
:Run the test until it crashes:
while ./node test/wpt/test-wasm-webapi.js ; do : ; done
How often does it reproduce? Is there a required condition?
The probability that any given test run crashes appears to be low, but after sufficiently many runs, it inevitably crashes.
What is the expected behavior?
Many WPT error messages and expected failures, but no crash.
What do you see instead?
Many WPT error messages and expected failures, and eventually:
Additional information
Discovered while testing #42701. Reproduced both locally and on multiple CI systems.
Hopefully, we will add support for
fetch()
in theWPTRunner
soon, at which point these instructions will likely not lead to the crash, assuming the currently vast number ofENOENT
errors that occur when the WPTs attempt to usefetch()
is responsible for the crash within fs.However, once that happens and when these instructions do not reproduce the crash anymore, that does not mean that the underlying bug has been fixed.
If you find a simpler reproduction, please comment below :)
The text was updated successfully, but these errors were encountered: