Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL is not compliant to specification #42920

Closed
anonrig opened this issue Apr 29, 2022 · 0 comments · Fixed by #43190
Closed

URL is not compliant to specification #42920

anonrig opened this issue Apr 29, 2022 · 0 comments · Fixed by #43190
Labels
url Issues and PRs related to the legacy built-in url module.

Comments

@anonrig
Copy link
Member

anonrig commented Apr 29, 2022

Version

19.0.0

Platform

Darwin Yagizs-MBP 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:46:32 PDT 2022; root:xnu-8020.101.4~15/RELEASE_ARM64_T6000 arm64

Subsystem

No response

What steps will reproduce the bug?

No response

How often does it reproduce? Is there a required condition?

It's not compliant.

What is the expected behavior?

While working on the 256.256.256.256.256 bug on the URL parser, I realized that the tests pretty old for the compliance. The updated tests can be found from https://github.com/anonrig/url-js/blob/main/test/urltestdata.json

What do you see instead?

Compliance

Additional information

No response
@anonrig anonrig changed the title URL state machine is not specification compliant URL is not compliant to specification Apr 29, 2022
@anonrig anonrig mentioned this issue Apr 29, 2022
Closed
@VoltrexKeyva VoltrexKeyva added the url Issues and PRs related to the legacy built-in url module. label Apr 30, 2022
@F3n67u F3n67u mentioned this issue May 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test, url: update WHATWG URL parser to align with latest spec F3n67u/node
2 participants
@anonrig @VoltrexKeyva