Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test - test-performance-measure #42949

Closed
mhdawson opened this issue May 2, 2022 · 1 comment
Closed

Investigate flaky test - test-performance-measure #42949

mhdawson opened this issue May 2, 2022 · 1 comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@mhdawson
Copy link
Member

mhdawson commented May 2, 2022

Test

test-performance-measure

Platform

osx

Console output

node:assert:399
    throw err;
    ^

AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert.ok(duration > DELAY)

    at /Users/iojs/build/workspace/node-test-commit-osx-arm/nodes/osx11/test/parallel/test-performance-measure.js:12:12
    at Array.forEach (<anonymous>)
    at PerformanceObserver.<anonymous> (/Users/iojs/build/workspace/node-test-commit-osx-arm/nodes/osx11/test/parallel/test-performance-measure.js:11:22)
    at PerformanceObserver.<anonymous> (/Users/iojs/build/workspace/node-test-commit-osx-arm/nodes/osx11/test/common/index.js:438:15)
    at [kDispatch] (node:internal/perf/observe:308:19)
    at Immediate._onImmediate (node:internal/perf/observe:112:25)
    at process.processImmediate (node:internal/timers:471:21) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}

Node.js v19.0.0-pre


### Build links

- https://ci.nodejs.org/job/node-test-commit-osx-arm/5495/

### Additional information

_No response_
@mhdawson mhdawson added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label May 2, 2022
@tniessen tniessen changed the title Investigeate flaky test - test-performance-measure Investigate flaky test - test-performance-measure May 4, 2022
@smitley smitley mentioned this issue Sep 14, 2022
Closed
smitley added a commit to smitley/node that referenced this issue Sep 14, 2022
@smitley
test: fix test-performance-measure
1925e34 
Refs: nodejs#42949

Looking at the documentation for setTimeout
(https://nodejs.org/api/timers.html#settimeoutcallback-delay-args)
there is no guarantee that setTimeout won't complete early.

From the failure of nodejs#42949 this
is likely what happened.

I have updated the assert.ok test to allow some variation in
the test.
mhdawson pushed a commit that referenced this issue Sep 16, 2022
@smitley @mhdawson
test: fix test-performance-measure
0928897 
Refs: #42949

Looking at the documentation for setTimeout
(https://nodejs.org/api/timers.html#settimeoutcallback-delay-args)
there is no guarantee that setTimeout won't complete early.

From the failure of #42949 this
is likely what happened.

I have updated the assert.ok test to allow some variation in
the test.

PR-URL: #44637
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS pushed a commit that referenced this issue Sep 26, 2022
@smitley @RafaelGSS
test: fix test-performance-measure
7920402 
Refs: #42949

Looking at the documentation for setTimeout
(https://nodejs.org/api/timers.html#settimeoutcallback-delay-args)
there is no guarantee that setTimeout won't complete early.

From the failure of #42949 this
is likely what happened.

I have updated the assert.ok test to allow some variation in
the test.

PR-URL: #44637
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS pushed a commit that referenced this issue Sep 26, 2022
@smitley @RafaelGSS
test: fix test-performance-measure
aa6f095 
Refs: #42949

Looking at the documentation for setTimeout
(https://nodejs.org/api/timers.html#settimeoutcallback-delay-args)
there is no guarantee that setTimeout won't complete early.

From the failure of #42949 this
is likely what happened.

I have updated the assert.ok test to allow some variation in
the test.

PR-URL: #44637
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS pushed a commit that referenced this issue Sep 26, 2022
@smitley @RafaelGSS
test: fix test-performance-measure
8a68a80 
Refs: #42949

Looking at the documentation for setTimeout
(https://nodejs.org/api/timers.html#settimeoutcallback-delay-args)
there is no guarantee that setTimeout won't complete early.

From the failure of #42949 this
is likely what happened.

I have updated the assert.ok test to allow some variation in
the test.

PR-URL: #44637
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
juanarbol pushed a commit that referenced this issue Oct 4, 2022
@smitley @juanarbol
test: fix test-performance-measure
23f4c26 
Refs: #42949

Looking at the documentation for setTimeout
(https://nodejs.org/api/timers.html#settimeoutcallback-delay-args)
there is no guarantee that setTimeout won't complete early.

From the failure of #42949 this
is likely what happened.

I have updated the assert.ok test to allow some variation in
the test.

PR-URL: #44637
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
juanarbol pushed a commit that referenced this issue Oct 4, 2022
@smitley @juanarbol
test: fix test-performance-measure
5f67877 
Refs: #42949

Looking at the documentation for setTimeout
(https://nodejs.org/api/timers.html#settimeoutcallback-delay-args)
there is no guarantee that setTimeout won't complete early.

From the failure of #42949 this
is likely what happened.

I have updated the assert.ok test to allow some variation in
the test.

PR-URL: #44637
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
juanarbol pushed a commit that referenced this issue Oct 4, 2022
@smitley @juanarbol
test: fix test-performance-measure
e271c97 
Refs: #42949

Looking at the documentation for setTimeout
(https://nodejs.org/api/timers.html#settimeoutcallback-delay-args)
there is no guarantee that setTimeout won't complete early.

From the failure of #42949 this
is likely what happened.

I have updated the assert.ok test to allow some variation in
the test.

PR-URL: #44637
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
juanarbol pushed a commit that referenced this issue Oct 7, 2022
@smitley @juanarbol
test: fix test-performance-measure
9845ed6 
Refs: #42949

Looking at the documentation for setTimeout
(https://nodejs.org/api/timers.html#settimeoutcallback-delay-args)
there is no guarantee that setTimeout won't complete early.

From the failure of #42949 this
is likely what happened.

I have updated the assert.ok test to allow some variation in
the test.

PR-URL: #44637
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
juanarbol pushed a commit that referenced this issue Oct 10, 2022
@smitley @juanarbol
test: fix test-performance-measure
fadd635 
Refs: #42949

Looking at the documentation for setTimeout
(https://nodejs.org/api/timers.html#settimeoutcallback-delay-args)
there is no guarantee that setTimeout won't complete early.

From the failure of #42949 this
is likely what happened.

I have updated the assert.ok test to allow some variation in
the test.

PR-URL: #44637
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
juanarbol pushed a commit that referenced this issue Oct 11, 2022
@smitley @juanarbol
test: fix test-performance-measure
aae8ff6 
Refs: #42949

Looking at the documentation for setTimeout
(https://nodejs.org/api/timers.html#settimeoutcallback-delay-args)
there is no guarantee that setTimeout won't complete early.

From the failure of #42949 this
is likely what happened.

I have updated the assert.ok test to allow some variation in
the test.

PR-URL: #44637
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
@smitley @guangwong
test: fix test-performance-measure
3a59b2b 
Refs: nodejs/node#42949

Looking at the documentation for setTimeout
(https://nodejs.org/api/timers.html#settimeoutcallback-delay-args)
there is no guarantee that setTimeout won't complete early.

From the failure of nodejs/node#42949 this
is likely what happened.

I have updated the assert.ok test to allow some variation in
the test.

PR-URL: nodejs/node#44637
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
@smitley @guangwong
test: fix test-performance-measure
4c626d1 
Refs: nodejs/node#42949

Looking at the documentation for setTimeout
(https://nodejs.org/api/timers.html#settimeoutcallback-delay-args)
there is no guarantee that setTimeout won't complete early.

From the failure of nodejs/node#42949 this
is likely what happened.

I have updated the assert.ok test to allow some variation in
the test.

PR-URL: nodejs/node#44637
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@lpinca
Copy link
Member

lpinca commented Jun 29, 2023

This was fixed by #44637.

@lpinca lpinca closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lpinca @mhdawson