-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: regression in openssl #42976
Labels
Comments
mscdex
added
confirmed-bug
Issues with confirmed bugs.
openssl
Issues and PRs related to the OpenSSL dependency.
labels
May 5, 2022
I can duplicate this. /cc @danbev |
I'll open a PR to revert that commit. |
danbev
added a commit
to danbev/node
that referenced
this issue
May 5, 2022
This reverts commit 7fae2c9. Refs: nodejs#42976
I think that it is time for at least a basic addon building unit test - 18.1.0 is seriously broken because of this |
mmomtchev
added a commit
to mmomtchev/node-gdal-async
that referenced
this issue
May 9, 2022
Hope to ship the fix in a Node.js 18 release this week (as long as we do not hit any unexpected problems/delays). |
Closing, this was fixed months ago by #42978. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Version
18.1.0
Platform
Linux host2 5.15.0-25-generic #25-Ubuntu SMP Wed Mar 30 15:54:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Subsystem
openssl
What steps will reproduce the bug?
build a simple addon
How often does it reproduce? Is there a required condition?
always
What is the expected behavior?
addon is built
What do you see instead?
Additional information
commit 7fae2c9 breaks C++ addons which use any
openssl
headerThe text was updated successfully, but these errors were encountered: