Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: regression in openssl #42976

Closed
yanovich opened this issue May 5, 2022 · 6 comments
Closed

deps: regression in openssl #42976

yanovich opened this issue May 5, 2022 · 6 comments
Labels
confirmed-bug Issues with confirmed bugs. openssl Issues and PRs related to the OpenSSL dependency.

Comments

@yanovich
Copy link

yanovich commented May 5, 2022

Version

18.1.0

Platform

Linux host2 5.15.0-25-generic #25-Ubuntu SMP Wed Mar 30 15:54:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Subsystem

openssl

What steps will reproduce the bug?

build a simple addon

How often does it reproduce? Is there a required condition?

always

What is the expected behavior?

addon is built

What do you see instead?

$ yarn build 
yarn run v1.22.18
$ node-gyp configure --silent && node-gyp build --silent
make: Entering directory '/home/user/src/addon/build'
  CXX(target) Release/obj.target/addon/addon.o
In file included from /home/s/.cache/node-gyp/18.1.0/include/node/openssl/opensslconf.h:9,
                 from /home/s/.cache/node-gyp/18.1.0/include/node/openssl/macros.h:14,
                 from /home/s/.cache/node-gyp/18.1.0/include/node/openssl/evp.h:14,
                 from ../addon.cc:5:
/home/s/.cache/node-gyp/18.1.0/include/node/openssl/./opensslconf_asm.h:97:11: fatal error: ./archs/linux-x86_64/asm/include/openssl/opensslconf.h: No such file or directory
   97 | # include "./archs/linux-x86_64/asm/include/openssl/opensslconf.h"
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [addon.target.mk:120: Release/obj.target/addon/addon.o] Error 1
$ head -n 5 addon.cc
#include <stdlib.h>
#include <string.h>
#include <iostream>

#include <openssl/evp.h>

Additional information

commit 7fae2c9 breaks C++ addons which use any openssl header

@yanovich
Copy link
Author

yanovich commented May 5, 2022

#42616

@mscdex mscdex added confirmed-bug Issues with confirmed bugs. openssl Issues and PRs related to the OpenSSL dependency. labels May 5, 2022
@mscdex
Copy link
Contributor

mscdex commented May 5, 2022

I can duplicate this.

/cc @danbev

@danbev
Copy link
Contributor

danbev commented May 5, 2022

I'll open a PR to revert that commit.

danbev added a commit to danbev/node that referenced this issue May 5, 2022
nodejs-github-bot pushed a commit that referenced this issue May 8, 2022
This reverts commit 7fae2c9.

Refs: #42976

PR-URL: #42978
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit that referenced this issue May 8, 2022
PR-URL: #42978
Refs: #42976
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@mmomtchev
Copy link
Contributor

I think that it is time for at least a basic addon building unit test - 18.1.0 is seriously broken because of this

mmomtchev added a commit to mmomtchev/node-gdal-async that referenced this issue May 9, 2022
@BethGriggs
Copy link
Member

Hope to ship the fix in a Node.js 18 release this week (as long as we do not hit any unexpected problems/delays).

RafaelGSS pushed a commit that referenced this issue May 10, 2022
This reverts commit 7fae2c9.

Refs: #42976

PR-URL: #42978
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS pushed a commit that referenced this issue May 10, 2022
PR-URL: #42978
Refs: #42976
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@bnoordhuis
Copy link
Member

Closing, this was fixed months ago by #42978.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed-bug Issues with confirmed bugs. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Development

No branches or pull requests

6 participants