Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.2.4 Planning #4321

Closed
jasnell opened this issue Dec 17, 2015 · 21 comments
Closed

Release 4.2.4 Planning #4321

jasnell opened this issue Dec 17, 2015 · 21 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@jasnell
Copy link
Member

jasnell commented Dec 17, 2015

Just an fyi.. @nodejs/lts @nodejs/ctc ... I will be starting to pull together the v4.2.4 release proposal tomorrow. We currently have 150+ commits staged and waiting in v4.x-staging. I don't want to let that continue to grow. The current plan is to get the proposal ready by tomorrow with a release on Tuesday of next week.
@jasnell jasnell added the meta Issues and PRs related to the general management of the project. label Dec 17, 2015
@rvagg
Copy link
Member

rvagg commented Dec 17, 2015

It's probably worth listing things that have not made it in to v4.x-staging since v4.2.1, if anyone has the time to look over these and comment on things they think should have made it but haven't please do so! This discussion is important to continue having so early in our figuring-out-how-to-LTS phase.

branch-diff v4.x-staging master --exclude-label=semver-major,semver-minor,dont-land-on-v4.x --start-ref=v4.2.1 --group

  • [da5cdc2207] - assert: accommodate ES6 classes that extend Error (Rich Trott) #4166
  • [bb1bd76395] - async_wrap: call callback in destructor (Trevor Norris) #3461
  • [80a66ba6ae] - async_wrap: new instances get uid (Trevor Norris) #3461
  • [a4e9487aae] - async_wrap: allow some hooks to be optional (Trevor Norris) #3461
  • [ec836547c4] - buffer: fix range checking for slowToString (Matt Loring) #4019
  • [7239494b54] - buffer: Prevent Buffer constructor deopt (Bryce Baril) #4158
  • [93739f48ff] - buffer: default to UTF8 in byteLength() (Tom Gallacher) #4010
  • [22478d3669] - buffer: move checkFloat from lib into src (Matt Loring) #3763
  • [0ed3a7c11b] - buffer: let WriteFloatGeneric silently drop values (P.S.V.R)
  • [827ee498e3] - buffer: neuter external nullptr buffers (Fedor Indutny) #3624
  • [95dd890b32] - build: add "--partly-static" build options (Super Zheng) #4152
  • [d461a0763f] - build: omit -gline-tables-only for --enable-asan (Ben Noordhuis) #3680
  • [15bcbf853e] - build: Updates for AIX npm support - part 1 (Michael Dawson) #3114
  • [34b535f4ca] - child_process: flush consuming streams (Dave) #4071
  • [84dea1bd0c] - configure: fix arm vfpv2 (Jörg Krause) #4203
  • [9aee2c0e26] - console: use 'label' argument for time and timeEnd (Roman Reiss) #3590
  • [181816ea16] - crypto: fix native module compilation with FIPS (Stefan Budeanu) #4023
  • [c83d9b7065] - crypto: update root certificates (Ben Noordhuis) #3951
  • [56a2b9a246] - crypto: disable crypto.createCipher in FIPS mode (Stefan Budeanu) #3754
  • [b33e9da8f9] - debugger: introduce exec method for debugger (Jackson Tian)
  • [a95eb5c671] - debugger: also exit when the repl emits 'exit' (Felix Böhm) #2369
  • [36ac3d642e] - deps: backport 8d6a228 from the v8's upstream (Fedor Indutny) #4259
  • [69b94ec55c] - deps: upgrade libuv to 1.8.0 (Saúl Ibarra Corretgé) #4276
  • [e2dec98837] - deps: upgrade to V8 4.7.80.25 (Ali Ijaz Sheikh) #4160
  • [1e324d883e] - deps: backport bc2e393 from v8 upstream (evan.lucas) #4106
  • [d9d050d396] - deps: cherry-pick 68e89fb from v8's upstream (Fedor Indutny) #4106
  • [edfc8cde04] - deps: backport 1ee712a from V8 upstream (Julien Gilli) #4106
  • [8a43a3d761] - deps: upgrade V8 to 4.7.80.24 (Ali Ijaz Sheikh) #4106
  • [f88b1576e5] - deps: backport a7e50a5 from upstream v8 (Ben Noordhuis) nodejs/node-private#6
  • [004778e6df] - deps: backport 6df9a1d from upstream v8 (Ben Noordhuis) nodejs/node-private#6
  • [ab25589f59] - deps: backport 819b40a from V8 upstream (Michaël Zasso) #3937
  • [70405d47c3] - deps: backport bc2e393 from v8 upstream (evan.lucas) #3792
  • [81e32ccdfe] - deps: cherry-pick 68e89fb from v8's upstream (Fedor Indutny) #3779
  • [2930867a2b] - deps: update V8 to 4.6.85.31 (Michaël Zasso) #3698
  • [df9c4a6a1f] - deps: upgrade npm to 3.3.12 (Rebecca Turner) #3685
  • [507fc53e37] - deps: upgrade npm to 3.3.10 (Rebecca Turner) #3599
  • [6456fcf4f3] - deps: update V8 to 4.6.85.28 (Michaël Zasso) #3484
  • [68471dd37c] - deps: fix upgrade to npm 3.3.6 (Rebecca Turner) #3494
  • [41923c0c07] - deps: upgrade npm to 3.3.6 (Rebecca Turner) #3310
  • [a334ddc467] - _Revert_ "deps: backport 03ef3cd from V8 upstream" (Ali Ijaz Sheikh) #3237
  • [6fff47ffac] - deps: backport 03ef3cd from V8 upstream (Ali Ijaz Sheikh) #3165
  • [680dda8023] - dns: remove nonexistant exports.ADNAME (Roman Reiss) #3051
  • [a8854e5b59] - doc: document the cache parameter for fs.realpathSync (Jackson Tian) #4285
  • [9e1b7aa874] - doc: document backlog for server.listen() variants (Jan Schär) #4025
  • [435d571f22] - doc: update AUTHORS list (Rod Vagg) #4183
  • [3b3061365a] - doc: update irc channels: #node.js and #node-dev (Nelson Pecora) #2743
  • [9538fd02e5] - doc: clarify error events in HTTP module documentation (Lenny Markus) #4275
  • [c6efd535e4] - doc: fix improper http.get sample code (Hideki Yamamura) #4263
  • [498c9adb08] - doc: add CTC meeting minutes 2015-10-28 (Rod Vagg) #3661
  • [671347cf13] - doc: fixup socket.remoteAddress (Arthur Gautier) #4198
  • [f050cab3d8] - doc: copyedit console doc (Rich Trott) #4225
  • [1a21a5368b] - doc: move description of 'equals' method to right place (janriemer) #4227
  • [9a9c5259bf] - doc: Fixing broken links to the v8 wiki (Tom Gallacher) #4241
  • [37ed05b8c1] - doc: copyedit child_process doc (Rich Trott) #4188
  • [e47ae5808b] - doc: copyedit buffer doc (Rich Trott) #4187
  • [70fb06a90b] - doc: clarify assert.fail doc (Rich Trott) #4186
  • [e3187cc81e] - doc: copyedit addons doc (Rich Trott) #4185
  • [931ab967ff] - doc: add calvinmetcalf to collaborators (Calvin Metcalf) #4218
  • [01ce23148b] - doc: add mcollina to collaborators (Matteo Collina) #4220
  • [bd8753aabf] - doc: add rmg to collaborators (Ryan Graham) #4219
  • [73a9a6fc92] - doc: harmonize description of ca argument (Ben Noordhuis) #4213
  • [dfc8bedbc5] - doc: change references from node to Node.js (Roman Klauke) #4177
  • [a1388bb545] - doc: add brief Node.js overview to README (wurde) #4174
  • [2a29b70b37] - doc: url.format - true slash postfix behaviour (fansworld-claudio) #4119
  • [1d8c92e8b4] - doc: s/node.js/Node.js in readme (Rod Vagg) #3998
  • [cc2ceb6cb9] - doc: improve child_process.markdown wording (yorkie) #4138
  • [5c6aac4d27] - doc: add JungMinu to collaborators (Minwoo Jung) #4143
  • [7b09aade84] - doc: add iarna to collaborators (Rebecca Turner) #4144
  • [2cf4e388ca] - doc: add zkat to collaborators (Kat Marchán) #4142
  • [7e4f22ca13] - doc: update links to use https where possible (jpersson) #4054
  • [14b3aab7d2] - doc: add links and backticks around names (jpersson) #4054
  • [55b1eccae6] - doc: move fs.existsSync() deprecation message (Martin Forsberg) #3942
  • [406c596fbf] - doc: add warning about Windows process groups (Roman Klauke) #3681
  • [9f71a3109e] - doc: Describe FIPSDIR environment variable (Stefan Budeanu) #3752
  • [b7cc19c8f5] - doc: add final full stop in CONTRIBUTING.md (Emily Aviva Kapor-Mater) #3576
  • [052611b0d1] - doc: add TSC meeting minutes 2015-10-21 (Rod Vagg) #3480
  • [0a0926e863] - doc: add TSC meeting minutes 2015-10-14 (Rod Vagg) #3463
  • [cba5d2b948] - doc: add TSC meeting minutes 2015-09-30 (Rod Vagg) #3235
  • [b78de124d6] - doc: add TSC meeting minutes 2015-10-07 (Rod Vagg) #3364
  • [cdfa271164] - doc: update AUTHORS list (Rod Vagg)
  • [7a518788e9] - doc, test: symbols as event names (Bryan English) #4151
  • [2e38079ea4] - docs: fs - remove encoding list and link to buffer (fansworld-claudio)
  • [1594198600] - fs: return null error on readFile() success (Zheng Chaoping) #3740
  • [8c35903ba3] - fs,doc: use target instead of destination (yorkie) #3912
  • [6e40bf0659] - gitignore: don't ignore 'debug' in deps/npm (Rebecca Turner) #3599
  • [8625a3815e] - http: remove unneeded cb check from setTimeout() (Ashok Suthar) #3631
  • [b2e7a4d479] - installer: install the tick processor (Matt Loring) #3032
  • [cf0130dc0d] - lib: return boolean from child.send() (Rich Trott) #3577
  • [aaf9b488e2] - lib,test: update let to const where applicable (Sakthipriyan Vairamani) #3152
  • [9adc6a6bd0] - lttng: update flags for gc tracing (Glen Keane) #3388
  • [dfee4e3712] - module: fix column offsets in errors (Tristian Flanagan) #2867
  • [ee72ee7531] - module,repl: remove repl require() hack (Ben Noordhuis) #4026
  • [2a60e2ad71] - module,src: do not wrap modules with -1 lineOffset (cjihrig) #4298
  • [9472a0cfad] - net: small code cleanup (Jan Schär) #3943
  • [d3c498b1b7] - node: remove unused variables in AppendExceptionLine (Yazhong Liu) #4264
  • [d2c8ba5248] - node: s/doNTCallbackX/nextTickCallbackWithXArgs/ (Rod Vagg) #4167
  • [494227bb03] - node: improve GetActiveRequests performance (Trevor Norris) #3375
  • [aad6b9f0eb] - repl: display error message when loading directory (Prince J Wesley) #4170
  • [213ede6cee] - repl: fix require('3rdparty') regression (Ben Noordhuis) #4215
  • [459b106d6c] - repl: attach location info to syntax errors (cjihrig) #4013
  • [ce2471673f] - src: remove unused BITS_PER_LONG macro (Ben Noordhuis) #4290
  • [b799a74709] - src: fix line numbers on core errors (cjihrig) #4254
  • [c311b61430] - src: fix deprecation message for ErrnoException (Martin von Gagern) #4269
  • [b47d82316c] - src: refactor vcbuild configure args creation (Rod Vagg) #3399
  • [1ec09b0449] - src: don't print garbage errors (cjihrig) #4112
  • [e6e78910af] - src: use GetCurrentProcessId() for process.pid (Ben Noordhuis) #4163
  • [46af39768d] - src: define Is* util functions with macros (cjihrig) #4118
  • [a9c0c65f9e] - src: define getpid() based on OS (cjihrig) #4146
  • [0966ab9996] - src: force line buffering for stderr (Rich Trott) #3701
  • [9b024422cd] - _Revert_ "src: fix stuck debugger process" (Ben Noordhuis) #3585
  • [ff877e93e1] - src: fix stuck debugger process (Liang-Chi Hsieh) #2778
  • [292218828e] - stream: be less eager with readable flag (Brian White) #4141
  • [cc0342a517] - streams: update .readable/.writable to false (Brian White) #4083
  • [2859f9ef92] - test: fix debug-port-cluster flakiness (Ben Noordhuis) #4310
  • [cb0b4a6bc0] - test: add test for debugging one line files (cjihrig) #4298
  • [0b9c3a30d6] - test: add test for tls.parseCertString (Evan Lucas) #4283
  • [7598ed6cc0] - test: parallelize test-repl-persistent-history (Jeremiah Senkpiel) #4247
  • [668449ad14] - test: use regular timeout times for ARMv8 (Jeremiah Senkpiel) #4248
  • [23e7703c85] - test: fix http-many-ended-pipelines flakiness (Santiago Gimeno) #4041
  • [3b94991bda] - test: fix tls-inception flakiness (Santiago Gimeno) #4195
  • [86a3bd09b0] - test: fix tls-inception (Santiago Gimeno) #4195
  • [1e89830a11] - test: don't assume openssl s_client supports -ssl3 (Ben Noordhuis) #4204
  • [a04721df66] - test: check range fix for slowToString (Sakthipriyan Vairamani) #4019
  • [19e06d71cf] - test: skip long path tests on non-Windows (Rafał Pocztarski) #4116
  • [afd512253d] - test: mark test-cluster-shared-leak flaky (Rich Trott) #4162
  • [cf6529985e] - test: fix time resolution constraint (Gireesh Punathil) #3981
  • [dc09bbe3ee] - test: fix test-repl-tab-complete after V8 upgrade (Ali Ijaz Sheikh) #4106
  • [c79b145abc] - test: fix flaky test-net-socket-local-address (Rich Trott) #4109
  • [a40b9cab0a] - test: skip instead of fail when mem constrained (Michael Cornacchia) #3697
  • [49b5445cbc] - test: improve cluster-disconnect-handles test (Brian White) #4084
  • [b3313aa603] - test: eliminate multicast test FreeBSD flakiness (Rich Trott) #4042
  • [f2e319b757] - test: move ArrayStream to common (cjihrig) #4027
  • [20acc60615] - test: use platform-based timeout for reliability (Rich Trott) #4015
  • [41519fd1a4] - test: add TAP diagnostic message for retried tests (Rich Trott) #3960
  • [174d4e484e] - test: http complete list of non-concat headers (Bryan English) #3930
  • [6de82c69a0] - test: fix race condition in unrefd interval test (Michael Cornacchia) #3550
  • [339d3840c8] - test: add OS X to module loading error test (Evan Lucas) #3901
  • [82022a79b0] - test: more regression tests for minDHSize option (Ben Noordhuis) #3629
  • [cddf358f68] - test: add regression test for 512 bits DH key (Ben Noordhuis) #3629
  • [6d6bc5d9d8] - test: mark http-pipeline-flood flaky (Rich Trott) #3616
  • [fbcd687c08] - timers: optimize callback call: bind -> arrow (Andrei Sedoi) #4038
  • [483a41c0ad] - tls: copy client CAs and cert store on CertCb (Fedor Indutny) #3537
  • [e0bb118a1d] - tls_wrap: inherit from the AsyncWrap first (Fedor Indutny) #4268
  • [c0cb80ec3b] - tls_wrap: slice buffer properly in ClearOut (Fedor Indutny) #4184
  • [d63cceeb10] - tools: add .editorconfig (ronkorving) #2993
  • [8c4deff55d] - tools: update certdata.txt (Ben Noordhuis) #3951
  • [7b4516356a] - tools: add tap output to cpplint (Johan Bergström) #3448
  • [25cd455407] - tools: enforce throw new Error() with lint rule (Rich Trott) #3714
  • [35f2f64edd] - tools: Use throw new Error() consistently (Rich Trott) #3714
  • [754061f3ae] - tools: update npm test tooling for 3.3.10+ (Rebecca Turner) #3599
  • [be65f5f250] - tools: fix gyp to work on MacOSX without XCode (Shigeki Ohtsu) iojs/io.js#1325
  • [1d65b99d5d] - tools: update gyp to b3cef02 (Imran Iqbal) #3487
  • [b0e7b362c2] - tools: enable prefer-const eslint rule (Sakthipriyan Vairamani) #3152
  • [9b8886446d] - tools: ensure npm always uses the local node (Jeremiah Senkpiel) #3489
  • [349fbe96ae] - tools: update test-npm to work with npm 3 (Rebecca Turner) #3489
  • [f5445db4cd] - tools: use absolute paths in test-npm (Rebecca Turner) #3309
  • [4b267df93e] - udp: remove a needless instanceof Buffer check (ronkorving) #4301
  • [6526ae7b37] - util: determine object types in C++ (cjihrig) #4100
  • [82b8355e12] - util: fix constructor/instanceof checks (Brian White) #3385
  • [04b1a2f756] - util: move .decorateErrorStack to internal/util (Ben Noordhuis) #4026
  • [8ca412b7a3] - util: add decorateErrorStack() (cjihrig) #4013
  • [9d0396cd63] - util: use Object.create(null) for dictionary object (Minwoo Jung) #3831
  • [5169311bf9] - util,src: allow lookup of hidden values (cjihrig) #3988
  • [b244f139bf] - vm: remove Watchdog dependency on Environment (Ido Ben-Yair) #3274

@jasnell
Copy link
Member Author

jasnell commented Dec 17, 2015

+1 thanks @rvagg! I think most of these should already have the lts-watch
label applied if they are candidates. It's possible that a few got through
without that, or that some could have been mislabeled. In general, nearly
all the doc and test related commits are likely OK to land with a few
exceptions. I'll be going through these in detail tomorrow.
On Dec 16, 2015 6:27 PM, "Rod Vagg" notifications@github.com wrote:

It's probably worth listing things that have not made it in to
v4.x-staging since v4.2.1, if anyone has the time to look over these and
comment on things they think should have made it but haven't please do so!
This discussion is important to continue having so early in our
figuring-out-how-to-LTS phase.

branch-diff v4.x-staging master
--exclude-label=semver-major,semver-minor,dont-land-on-v4.x
--start-ref=v4.2.1 --group

—
Reply to this email directly or view it on GitHub
#4321 (comment).

@MylesBorins
Copy link
Contributor

I've been going through that list pretty regularly and was planning another pass tomorrow morning. If I recall a good number of them were less than two weeks old and needed a little more time to settle in.

@alexlamsl
Copy link

nodejs/node-private? 😕

@jasnell
Copy link
Member Author

jasnell commented Dec 17, 2015

@alexlamsl ... not sure I follow. This would be a normal LTS maintenance release, not a sensitive security update. Some of the commits in @rvagg's originated from nodejs/node-private, yes, but those are already disclosed as they already landed in nodejs/node master. There's no need to discuss it in nodejs/node-private.

@alexlamsl
Copy link

@jasnell as I'm not part of the inner circle, I've never come across that repo before hence got curious.

Thanks a lot for the clarification!

@jasnell
Copy link
Member Author

jasnell commented Dec 17, 2015

@alexlamsl ..yeah, the nodejs/node-private repo is a mirror of nodejs/node that is used strictly to work on and review sensitive security changes that have not yet been openly disclosed.

@jasnell
Copy link
Member Author

jasnell commented Dec 17, 2015

Here is the list of commits that are currently staged in v4.x-staging. There is one that was flagged as semver-minor after it had already landed in v4.x-staging. That will not be landed in v4.x and it'll have to be backed out of staging once the release is done.

Update: going through the commits now, putting a check mark on the items that definitely should pull over into v4.x ... note: this list has not yet been reconciled with @rvagg's list above

  • [25cded4467] - domains: fix handling of uncaught exceptions (Julien Gilli) #3884
  • [7ab7402ea0] - meta: remove use of profanity in source (Myles Borins) #4122
  • [40030cc173] - doc: standardize references to node.js in docs (Scott Buchanan) #4136
  • [84bb29fb47] - doc: fix internal link to child.send() (Luigi Pinca) #4089
  • [fa41f49e3b] - doc: reword https.Agent example text (Jan Krems) #4075
  • [79720aaec2] - test: refactor test-http-exit-delay (Rich Trott) #4055
  • [535855cd92] - stream_wrap: error if stream has StringDecoder (Fedor Indutny) #4031
  • [a29d6d33e6] - configure: v8_use_snapshot should be true (Fedor Indutny) #3962
  • [e73d697a46] - build: update signtool description, add url (Rod Vagg) #4011
  • [5d3c64fc88] - test: fix cluster-disconnect-handles flakiness (Santiago Gimeno) #4009
  • [2bb9c1c3b1] - buffer: fix writeInt{B,L}E for some neg values (Peter A. Bigot) #3994
  • [66d6990bde] - test: don't check the # of chunks in test-http-1.0 (Santiago Gimeno) #3961
  • [c6b92b85c4] - test: fix cluster-worker-isdead (Santiago Gimeno) #3954
  • [8b4038a54e] - doc: add HTTP working group (James M Snell) #3919
  • [f03eb81a8f] - doc: update WORKING_GROUPS.md - add missing groups (Michael Dawson) #3450
  • [04e1e9c218] - test: add test for repl.defineCommand() (Bryan English) #3908
  • [ae7c71ee67] - doc: fix the exception description (yorkie) #3658
  • [88c17f8c8a] - configure: use __ARM_ARCH to determine arm version (João Reis) #4123
  • [d1b51bdde4] - configure: respect CC_host in host arch detection (João Reis) #4117
  • [b7a22d4b6f] - doc: clarify v4.2.3 notable items (Rod Vagg) #4155
  • [c3ec5d0400] - deps: Updated node LICENSE file with new npm license (Kat Marchán) #4110
  • [7c528b780f] - test: mark test flaky on FreeBSD (Rich Trott) #4016
  • [09bb297b4e] - test: mark cluster-net-send test flaky on windows (Rich Trott) #4006
  • [503e3e1ad7] - test: remove flaky designation from ls-no-sslv3 (Rich Trott) #3620
  • [7fea7fb104] - doc: fix color of linked code blocks (jpersson) #4068
  • [75e73d1abd] - test: mark fork regression test flaky on windows (Rich Trott) #4005
  • [e65682d614] - doc: fix typo in README (Rich Trott) #4000
  • [d560e3789c] - doc: message.header duplication correction (Bryan English) #3997
  • [d184c70282] - test: skip test if in FreeBSD jail (Rich Trott) #3995
  • [664941f3a3] - test: fix test-domain-exit-dispose-again (Julien Gilli) #3990
  • [ed18135c75] - doc: replace sane with reasonable (Lewis Cowper) #3980
  • [950af45732] - test: remove flaky status for cluster test (Rich Trott) #3975
  • [edbe732661] - test: address flaky test-http-client-timeout-event (Rich Trott) #3968
  • [c7e9a70edc] - doc: fix rare case of misaligned columns (Roman Reiss) #3948
  • [02dcdcbb34] - net: add local address/port for better errors (Jan Schär) #3946
  • [8a6ec72034] - doc: fix broken references (Alexander Gromnitsky) #3944
  • [e2dee8df0b] - test: retry on smartos if ECONNREFUSED (Rich Trott) #3941
  • [124ece7a01] - doc: add reference for buffer.inspect() (cjihrig) #3921
  • [13e8b843b7] - doc: clarify module loading behavior (cjihrig) #3920
  • [a655584249] - test: avoid test timeouts on rpi (Stefan Budeanu) #3902
  • [17176a939c] - test: fix flaky test-child-process-spawnsync-input (Rich Trott) #3889
  • [e99b1ce05a] - test: move test-specific function out of common (Rich Trott) #3871
  • [8a264ae41a] - module: cache regular expressions (Evan Lucas) #3869
  • [654192ff9f] - test: module loading error fix solaris node5: test-module-loading-error.js fails #3798 (fansworld-claudio) #3855
  • [7b294bb112] - test: skip test if FreeBSD jail will break it (Rich Trott) #3839
  • [93b3a378a7] - test: fix flaky SmartOS test (Rich Trott) #3830
  • [44177f0fba] - test: run pipeline flood test in parallel (Rich Trott) #3811
  • [112b602709] - build: fix --with-intl=system-icu for x-compile (Steven R. Loomis) #3808
  • [fe9baa7106] - querystring: Parse multiple separator characters (Yosuke Furukawa) #3807
  • [2c52bbcbf8] - child_process: add safety checks on stdio access (cjihrig) #3799
  • [16ebaf62a7] - buffer: let WriteFloatGeneric silently drop values (P.S.V.R)
  • [1889593e73] - test: skip/replace weak crypto tests in FIPS mode (Stefan Budeanu) #3757
  • [70ccc9e96e] - test: stronger crypto in test fixtures (Stefan Budeanu) #3759
  • [dd475dcd3f] - test: increase crypto strength for FIPS standard (Stefan Budeanu) #3758
  • [6f770af9a8] - test: add hasFipsCrypto to test/common.js (Stefan Budeanu) #3756
  • [7481deefe3] - test: add test for invalid DSA key size (Stefan Budeanu) #3756
  • [d235a005f4] - crypto: DSA parameter validation in FIPS mode (Stefan Budeanu) #3756
  • [8156e14afe] - tls: Use SHA1 for sessionIdContext in FIPS mode (Stefan Budeanu) #3755
  • [6c8dcc6e52] - cluster: remove handles when disconnecting worker (Ben Noordhuis) #3677
  • [fa4846e4e7] - child_process: don't fork bomb ourselves from -e (Ben Noordhuis) #3575
  • [511c1e72c8] - doc: numeric flags to fs.open (Carl Lei) #3641
  • [660b688527] - test: numeric flags to fs.open (Carl Lei) #3641
  • [b96f2a81d3] - doc: clarify that fs streams expect blocking fd (Carl Lei) #3641
  • [8c2be35f9f] - tls: remove util and calls to util.format (Myles Borins) #3456
  • [3bcfbce6fc] - doc: Adding best practises for crypto.pbkdf2 (Tom Gallacher) #3290
  • [7d3acf13a3] - doc: update WORKING_GROUPS.md to include Intl (Steven R. Loomis) #3251
  • [5f431b72a9] - deps: backport 819b40a from V8 upstream (Michaël Zasso) #3938
  • [ec5c8d7443] - doc: sort repl alphabetically (Tristian Flanagan) #3859
  • [7bd728ed73] - doc: consistent reference-style links (Bryan English) #3845
  • [bc52cd50f4] - doc: address use of profanity in code of conduct (James M Snell) #3827
  • [1d5cbe75b0] - doc: reword message.headers to indicate they are not read-only (Tristian Flanagan) #3814
  • [852b4c00f0] - doc: clarify duplicate header handling (Bryan English) #3810
  • [d94abad6be] - doc: replace head of readme with updated text (Rod Vagg) #3482
  • [4a40b27834] - docs: improve discoverability of Code of Conduct (Ashley Williams) #3774
  • [24f40eafe8] - test: refactor test-http-pipeline-flood (Rich Trott) #3636
  • [b084554e88] - test: fix flaky test test-http-pipeline-flood (Devin Nakamura) #3636
  • [ff6d7e3ebd] - doc: repl: add defineComand and displayPrompt (Bryan English) #3765
  • [fbbc4e5cd7] - doc: document release types in readme (Rod Vagg) #3482
  • [d28c35a8ec] - doc: add link to [customizing util.inspect colors]. (Jesse McCarthy) #3749
  • [a7a253916a] - doc: sort tls alphabetically (Tristian Flanagan) #3662
  • [02df0a95b4] - doc: sort stream alphabetically (Tristian Flanagan) #3662
  • [e51a7a6d5b] - doc: sort net alphabetically (Tristian Flanagan) #3662
  • [e758784690] - doc: sort process alphabetically (Tristian Flanagan) #3662
  • [bb9720c05f] - doc: sort zlib alphabetically (Tristian Flanagan) #3662
  • [35b1be32b6] - doc: sort util alphabetically (Tristian Flanagan) #3662
  • [aca9f2919a] - doc: sort https alphabetically (Tristian Flanagan) #3662
  • [2961eba226] - doc: sort http alphabetically (Tristian Flanagan) #3662
  • [b0974c7ef6] - doc: sort modules alphabetically (Tristian Flanagan) #3662
  • [4a379861f1] - doc: sort readline alphabetically (Tristian Flanagan) #3662
  • [7740da732e] - doc: sort repl alphabetically (Tristian Flanagan) #3662
  • [f6fcb5ca84] - doc: sort string_decoder alphabetically (Tristian Flanagan) #3662
  • [3bb8a6afcb] - doc: sort timers alphabetically (Tristian Flanagan) #3662
  • [79fccc5da1] - doc: sort tty alphabetically (Tristian Flanagan) #3662
  • [639837ad85] - doc: sort url alphabetically (Tristian Flanagan) #3662
  • [47de95cb01] - doc: sort vm alphabetically (Tristian Flanagan) #3662
  • [482e15b0c8] - doc: sort querystring alphabetically (Tristian Flanagan) #3662
  • [ca136f600d] - doc: sort punycode alphabetically (Tristian Flanagan) #3662
  • [da4ecdd288] - doc: sort path alphabetically (Tristian Flanagan) #3662
  • [83979a497f] - doc: sort os alphabetically (Tristian Flanagan) #3662
  • [1292f360b2] - doc: sort globals alphabetically (Tristian Flanagan) #3662
  • [3be6ad38c9] - doc: sort fs alphabetically (Tristian Flanagan) #3662
  • [65b1045ee1] - doc: sort events alphabetically (Tristian Flanagan) #3662
  • [17d1ee8b62] - doc: sort errors alphabetically (Tristian Flanagan) #3662
  • [077a2ba65a] - doc: sort dgram alphabetically (Tristian Flanagan) #3662
  • [cb23440989] - doc: sort crypto alphabetically (Tristian Flanagan) #3662
  • [5835751822] - doc: sort dns alphabetically (Tristian Flanagan) #3662
  • [b3e5360a23] - doc: sort console alphabetically (Tristian Flanagan) #3662
  • [dc79480e80] - doc: sort cluster alphabetically (Tristian Flanagan) #3662
  • [deb7514463] - doc: sort child_process alphabetically (Tristian Flanagan) #3662
  • [6d67540145] - doc: sort buffer alphabetically (Tristian Flanagan) #3662
  • [eaf290d597] - doc: sort assert alphabetically (Tristian Flanagan) #3662
  • [5226d1ef83] - doc: add note on tls connection meta data methods (Tyler Henkel) #3746
  • [0ec94c29c3] - crypto: Improve error checking and reporting (Stefan Budeanu) #3753
  • [e2336f9724] - doc: add note to util.isBuffer (Evan Lucas) #3790
  • [a926659be4] - doc: add romankl to collaborators (Roman Klauke) #3725
  • [1bc89aad2b] - doc: add saghul as a collaborator (Saúl Ibarra Corretgé)
  • [d27f4409fa] - doc: add thealphanerd to collaborators (Myles Borins) #3723
  • [bf41a97311] - cluster: send suicide message on disconnect (cjihrig) #3720
  • [365760eed7] - test: use really invalid hostname (Sakthipriyan Vairamani) #3711
  • [3e3c639c75] - dns: prevent undefined values in results (Junliang Yan) #3696
  • [a14d16457a] - util: use regexp instead of str.replace().join() (qinjia) #3689
  • [b44b6af1a7] - test: Fix test-cluster-worker-exit.js for AIX (Imran Iqbal) #3666
  • [94694244f5] - doc: update lts description in the collaborator guide (James M Snell) #3668
  • [e0ae01264c] - doc: add LTS info to COLLABORATOR_GUIDE.md (Myles Borins) #3442
  • [fcb67ddf4d] - test: fix test-module-loading-error for musl (Hugues Malphettes) #3657
  • [480019862a] - doc: typo fix in readme.md (Sam P Gallagher-Bishop) #3649
  • [6383229e46] - test: fix test-net-persistent-keepalive for AIX (Imran Iqbal) #3646
  • [b6064ed3ca] - doc: fix wrong date and known issue in changelog.md (James M Snell) #3650
  • [a6d3a5764a] - doc: rename iojs-* groups to nodejs-* (Steven R. Loomis) #3634
  • [f5a1ab75f0] - repl: don't crash if cannot open history file (Evan Lucas) #3630
  • [19dde92364] - doc: fix crypto spkac function descriptions (Jason Gerfen) #3614
  • [48e10c3895] - test: fix path to module for repl test on Windows (Michael Cornacchia) #3608
  • [885edb478e] - doc: Updated streams simplified constructor API (Tom Gallacher) #3602
  • [27085bfc85] - module: remove unnecessary JSON.stringify (Andres Suarez) #3578
  • [feffea040e] - doc: made code spans more visible in the API docs (phijohns) #3573
  • [815b395998] - Add missing va_end before return (Ömer Fadıl Usta) #3565
  • [b44964e5d0] - doc: added what buf.copy returns (Manuel B) #3555
  • [4ef1e247ce] - test: add test-zlib-flush-drain (Myles Borins) #3534
  • [9866608a78] - zlib: only apply drain listener if given callback (Craig Cavalier) #3534
  • [97e650456b] - zlib: pass kind to recursive calls to flush (Myles Borins) #3534
  • [688ad38dab] - doc: fix function param order in assert doc (David Woods) #3533
  • [c2b1ee6744] - doc: add note about timeout delay > TIMEOUT_MAX (Guilherme Souza) #3512
  • [08e23eb352] - src: Revert "nix stdin _readableState.reading" (Roman Reiss) #3490
  • [28474efdde] - doc: add caveats of algs and key size in crypto (Shigeki Ohtsu) #3479
  • [21d8e4a5a7] - repl: To exit, press ^C again or type .exit. (Hemanth.HM) #3368
  • [464363d3d0] - doc: add method links in events.markdown (Alejandro Oviedo) #3187
  • [1ed4d6d14a] - doc: stdout/stderr can block when directed to file (Ben Noordhuis) #3170
  • [c5f2405a85] - docs: fs - change links to buffer encoding to Buffer class anchor (fansworld-claudio) #2796
  • [fcb06aff14] - build: fix configuring with prebuilt libraries (Markus Tzoe) #3135
  • [ab373756c8] - test: enhance fs-watch-recursive test (Sakthipriyan Vairamani) #2599
  • [bc683d1166] - deps: upgrade npm to 2.14.9 (Forrest L Norvell) #3686
  • [0e269a7f0b] - src: remove __builtin_bswap16 call (Ben Noordhuis) #4290 (depends on 28280f7)
  • [28280f76ed] - (SEMVER-MINOR) src: add BE support to StringBytes::Encode() (Bryon Leung) #3410

@jasnell
Copy link
Member Author

jasnell commented Dec 17, 2015

Slightly updated version of @rvagg's list... with checkboxes. going through them now and will update the list periodically, removing the ones that definitely should not land in v4.x-staging...

  • [da5cdc2207] - assert: accommodate ES6 classes that extend Error (Rich Trott) #4166
  • [bb1bd76395] - async_wrap: call callback in destructor (Trevor Norris) #3461
  • [80a66ba6ae] - async_wrap: new instances get uid (Trevor Norris) #3461
  • [a4e9487aae] - async_wrap: allow some hooks to be optional (Trevor Norris) #3461
  • [7239494b54] - buffer: Prevent Buffer constructor deopt (Bryce Baril) #4158
  • [93739f48ff] - buffer: default to UTF8 in byteLength() (Tom Gallacher) #4010
  • [0ed3a7c11b] - buffer: let WriteFloatGeneric silently drop values (P.S.V.R)
  • [95dd890b32] - build: add "--partly-static" build options (Super Zheng) #4152
  • [d461a0763f] - build: omit -gline-tables-only for --enable-asan (Ben Noordhuis) #3680
  • [15bcbf853e] - build: Updates for AIX npm support - part 1 (Michael Dawson) #3114
  • [34b535f4ca] - child_process: flush consuming streams (Dave) #4071
  • [84dea1bd0c] - configure: fix arm vfpv2 (Jörg Krause) #4203
  • [181816ea16] - crypto: fix native module compilation with FIPS (Stefan Budeanu) #4023
  • [c83d9b7065] - crypto: update root certificates (Ben Noordhuis) #3951
  • [56a2b9a246] - crypto: disable crypto.createCipher in FIPS mode (Stefan Budeanu) #3754
  • [25776f3ea1] - debugger: guard against call from non-node context (Ben Noordhuis) #4328
  • [a95eb5c671] - debugger: also exit when the repl emits 'exit' (Felix Böhm) #2369
  • [680dda8023] - dns: remove nonexistant exports.ADNAME (Roman Reiss) #3051
  • [9b21119e17] - doc: fix, modernize examples in docs (James M Snell) #4282
  • [f2bddc14f6] - doc: Typo in buffer.markdown referencing buf.write() (chrisjohn404) #4324
  • [4637168f81] - doc: fix link in addons.markdown (Nicholas Young) #4331
  • [a8854e5b59] - doc: document the cache parameter for fs.realpathSync (Jackson Tian) #4285
  • [9e1b7aa874] - doc: document backlog for server.listen() variants (Jan Schär) #4025
  • [435d571f22] - doc: update AUTHORS list (Rod Vagg) #4183
  • [3b3061365a] - doc: update irc channels: #node.js and #node-dev (Nelson Pecora) #2743
  • [9538fd02e5] - doc: clarify error events in HTTP module documentation (Lenny Markus) #4275
  • [c6efd535e4] - doc: fix improper http.get sample code (Hideki Yamamura) #4263
  • [498c9adb08] - doc: add CTC meeting minutes 2015-10-28 (Rod Vagg) #3661
  • [671347cf13] - doc: fixup socket.remoteAddress (Arthur Gautier) #4198
  • [f050cab3d8] - doc: copyedit console doc (Rich Trott) #4225
  • [1a21a5368b] - doc: move description of 'equals' method to right place (janriemer) #4227
  • [9a9c5259bf] - doc: Fixing broken links to the v8 wiki (Tom Gallacher) #4241
  • [37ed05b8c1] - doc: copyedit child_process doc (Rich Trott) #4188
  • [e47ae5808b] - doc: copyedit buffer doc (Rich Trott) #4187
  • [70fb06a90b] - doc: clarify assert.fail doc (Rich Trott) #4186
  • [e3187cc81e] - doc: copyedit addons doc (Rich Trott) #4185
  • [931ab967ff] - doc: add calvinmetcalf to collaborators (Calvin Metcalf) #4218
  • [01ce23148b] - doc: add mcollina to collaborators (Matteo Collina) #4220
  • [bd8753aabf] - doc: add rmg to collaborators (Ryan Graham) #4219
  • [73a9a6fc92] - doc: harmonize description of ca argument (Ben Noordhuis) #4213
  • [dfc8bedbc5] - doc: change references from node to Node.js (Roman Klauke) #4177
  • [a1388bb545] - doc: add brief Node.js overview to README (wurde) #4174
  • [2a29b70b37] - doc: url.format - true slash postfix behaviour (fansworld-claudio) #4119
  • [1d8c92e8b4] - doc: s/node.js/Node.js in readme (Rod Vagg) #3998
  • [cc2ceb6cb9] - doc: improve child_process.markdown wording (yorkie) #4138
  • [5c6aac4d27] - doc: add JungMinu to collaborators (Minwoo Jung) #4143
  • [7b09aade84] - doc: add iarna to collaborators (Rebecca Turner) #4144
  • [2cf4e388ca] - doc: add zkat to collaborators (Kat Marchán) #4142
  • [7e4f22ca13] - doc: update links to use https where possible (jpersson) #4054
  • [14b3aab7d2] - doc: add links and backticks around names (jpersson) #4054
  • [55b1eccae6] - doc: move fs.existsSync() deprecation message (Martin Forsberg) #3942
  • [406c596fbf] - doc: add warning about Windows process groups (Roman Klauke) #3681
  • [9f71a3109e] - doc: Describe FIPSDIR environment variable (Stefan Budeanu) #3752
  • [b7cc19c8f5] - doc: add final full stop in CONTRIBUTING.md (Emily Aviva Kapor-Mater) #3576
  • [052611b0d1] - doc: add TSC meeting minutes 2015-10-21 (Rod Vagg) #3480
  • [0a0926e863] - doc: add TSC meeting minutes 2015-10-14 (Rod Vagg) #3463
  • [cba5d2b948] - doc: add TSC meeting minutes 2015-09-30 (Rod Vagg) #3235
  • [b78de124d6] - doc: add TSC meeting minutes 2015-10-07 (Rod Vagg) #3364
  • [cdfa271164] - doc: update AUTHORS list (Rod Vagg)
  • [7a518788e9] - doc, test: symbols as event names (Bryan English) #4151
  • [8c35903ba3] - fs,doc: use target instead of destination (yorkie) #3912
  • [88de88b5a6] - http: Remove an unnecessary assignment (Bo Borgerson) #4323
  • [8625a3815e] - http: remove unneeded cb check from setTimeout() (Ashok Suthar) #3631
  • [cf0130dc0d] - lib: return boolean from child.send() (Rich Trott) #3577
  • [aaf9b488e2] - lib,test: update let to const where applicable (Sakthipriyan Vairamani) #3152
  • [9adc6a6bd0] - lttng: update flags for gc tracing (Glen Keane) #3388
  • [dfee4e3712] - module: fix column offsets in errors (Tristian Flanagan) #2867
  • [ee72ee7531] - module,repl: remove repl require() hack (Ben Noordhuis) #4026
  • [9472a0cfad] - net: small code cleanup (Jan Schär) #3943
  • [d3c498b1b7] - node: remove unused variables in AppendExceptionLine (Yazhong Liu) #4264
  • [d2c8ba5248] - node: s/doNTCallbackX/nextTickCallbackWithXArgs/ (Rod Vagg) #4167
  • [aad6b9f0eb] - repl: display error message when loading directory (Prince J Wesley) #4170
  • [213ede6cee] - repl: fix require('3rdparty') regression (Ben Noordhuis) #4215
  • [459b106d6c] - repl: attach location info to syntax errors (cjihrig) #4013
  • [b799a74709] - src: fix line numbers on core errors (cjihrig) #4254
  • [c311b61430] - src: fix deprecation message for ErrnoException (Martin von Gagern) #4269
  • [b47d82316c] - src: refactor vcbuild configure args creation (Rod Vagg) #3399
  • [1ec09b0449] - src: don't print garbage errors (cjihrig) #4112
  • [e6e78910af] - src: use GetCurrentProcessId() for process.pid (Ben Noordhuis) #4163
  • [46af39768d] - src: define Is* util functions with macros (cjihrig) #4118
  • [a9c0c65f9e] - src: define getpid() based on OS (cjihrig) #4146
  • [292218828e] - stream: be less eager with readable flag (Brian White) #4141
  • [cc0342a517] - streams: update .readable/.writable to false (Brian White) #4083
  • [852313af65] - test: try other ipv6 localhost alternatives (Brian White) #4325
  • [2859f9ef92] - test: fix debug-port-cluster flakiness (Ben Noordhuis) #4310
  • [0b9c3a30d6] - test: add test for tls.parseCertString (Evan Lucas) #4283
  • [7598ed6cc0] - test: parallelize test-repl-persistent-history (Jeremiah Senkpiel) #4247
  • [668449ad14] - test: use regular timeout times for ARMv8 (Jeremiah Senkpiel) #4248
  • [23e7703c85] - test: fix http-many-ended-pipelines flakiness (Santiago Gimeno) #4041
  • [3b94991bda] - test: fix tls-inception flakiness (Santiago Gimeno) #4195
  • [86a3bd09b0] - test: fix tls-inception (Santiago Gimeno) #4195
  • [1e89830a11] - test: don't assume openssl s_client supports -ssl3 (Ben Noordhuis) #4204
  • [19e06d71cf] - test: skip long path tests on non-Windows (Rafał Pocztarski) #4116
  • [afd512253d] - test: mark test-cluster-shared-leak flaky (Rich Trott) #4162
  • [cf6529985e] - test: fix time resolution constraint (Gireesh Punathil) #3981
  • [c79b145abc] - test: fix flaky test-net-socket-local-address (Rich Trott) #4109
  • [a40b9cab0a] - test: skip instead of fail when mem constrained (Michael Cornacchia) #3697
  • [49b5445cbc] - test: improve cluster-disconnect-handles test (Brian White) #4084
  • [b3313aa603] - test: eliminate multicast test FreeBSD flakiness (Rich Trott) #4042
  • [f2e319b757] - test: move ArrayStream to common (cjihrig) #4027
  • [20acc60615] - test: use platform-based timeout for reliability (Rich Trott) #4015
  • [41519fd1a4] - test: add TAP diagnostic message for retried tests (Rich Trott) #3960
  • [174d4e484e] - test: http complete list of non-concat headers (Bryan English) #3930
  • [6de82c69a0] - test: fix race condition in unrefd interval test (Michael Cornacchia) #3550
  • [339d3840c8] - test: add OS X to module loading error test (Evan Lucas) #3901
  • [82022a79b0] - test: more regression tests for minDHSize option (Ben Noordhuis) #3629
  • [cddf358f68] - test: add regression test for 512 bits DH key (Ben Noordhuis) #3629
  • [6d6bc5d9d8] - test: mark http-pipeline-flood flaky (Rich Trott) #3616
  • [fbcd687c08] - timers: optimize callback call: bind -> arrow (Andrei Sedoi) #4038
  • [483a41c0ad] - tls: copy client CAs and cert store on CertCb (Fedor Indutny) #3537
  • [e0bb118a1d] - tls_wrap: inherit from the AsyncWrap first (Fedor Indutny) #4268
  • [c0cb80ec3b] - tls_wrap: slice buffer properly in ClearOut (Fedor Indutny) #4184
  • [8c4deff55d] - tools: update certdata.txt (Ben Noordhuis) #3951
  • [7b4516356a] - tools: add tap output to cpplint (Johan Bergström) #3448
  • [25cd455407] - tools: enforce throw new Error() with lint rule (Rich Trott) #3714
  • [35f2f64edd] - tools: Use throw new Error() consistently (Rich Trott) #3714
  • [b0e7b362c2] - tools: enable prefer-const eslint rule (Sakthipriyan Vairamani) #3152
  • [9b8886446d] - tools: ensure npm always uses the local node (Jeremiah Senkpiel) #3489
  • [4b267df93e] - udp: remove a needless instanceof Buffer check (ronkorving) #4301
  • [0b43c08f44] - util: pass on additional error() args (Brian White) #4279
  • [6526ae7b37] - util: determine object types in C++ (cjihrig) #4100
  • [82b8355e12] - util: fix constructor/instanceof checks (Brian White) #3385
  • [04b1a2f756] - util: move .decorateErrorStack to internal/util (Ben Noordhuis) #4026
  • [8ca412b7a3] - util: add decorateErrorStack() (cjihrig) #4013
  • [5169311bf9] - util,src: allow lookup of hidden values (cjihrig) #3988

@evanlucas
Copy link
Contributor

[b33e9da8f9] - debugger: introduce exec method for debugger (Jackson Tian) looks semver-minor to me

EDIT: nevermind, it is already listed as such

@jasnell
Copy link
Member Author

jasnell commented Dec 17, 2015

Ok, I've paired the list in #4321 (comment) down to only the commits that should land in v4.x-staging. There's still a very large number of commits and most have landed only recently. Given that the we already have a long list of commits pending I propose that we move ahead with v4.2.4 using the commits already in v4.x-staging and push this second set of commits to another release in early January. @rvagg @nodejs/lts @nodejs/ctc ... thoughts?

@jasnell
Copy link
Member Author

jasnell commented Dec 17, 2015

Release Proposal here => #4336

@djphoenix
Copy link
Contributor

@jasnell why not to include this fix? #4165

@MylesBorins
Copy link
Contributor

@djphoenix I think it was decided to wait on the fix as it had only been in master a couple days when this release started.

We will be cutting another release early in the new year which, barring any weird regressions, will include that commit

@AndreasMadsen
Copy link
Member

Should the AsyncWrap commits not be included? See the conclusion in nodejs/Release#59 (comment)

@jasnell
Copy link
Member Author

jasnell commented Dec 24, 2015

Those will be bundled into 4.2.5. There will be a fairly quick turnaround
on that one. 4.2.5 will aggressively catch up as much as possible to the
current head (minus the minor and majors of course).
On Dec 23, 2015 2:13 PM, "Andreas Madsen" notifications@github.com wrote:

Should the AsyncWrap commits not be included? See the conclusion in nodejs/Release#59
(comment) nodejs/Release#59 (comment)

—
Reply to this email directly or view it on GitHub
#4321 (comment).

@chrisdickinson
Copy link
Contributor

One bit I noticed re: AsyncWrap is that we're not properly calling the pre and post functions for HTTP parserOnBody events when the TCP connection is consumed in C++ via JSStream, so that may require a subsequent patch release.

@AndreasMadsen
Copy link
Member

@chrisdickinson It is a known issue see: #3241

A known issue overview can be found at: nodejs/diagnostics#29

@chrisdickinson
Copy link
Contributor

@AndreasMadsen Ah, this is different — It's not that connecting to a server from inside the process is missing context, it's that all http incomingmessages lack context because they are consumed at the C++ layer, and the resulting parserOnBody callbacks are incorrectly made with fn->Call instead of MakeCallback. Issue is here: #4416

@Trott
Copy link
Member

Trott commented Dec 29, 2015

Since the release is done, can this be closed?

@MylesBorins
Copy link
Contributor

closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@chrisdickinson @jasnell @rvagg @MylesBorins @AndreasMadsen @evanlucas @Trott @djphoenix @alexlamsl