-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FATAL ERROR: v8::FromJust Maybe value is Nothing #43304
Comments
Possibly already fixed in #42874. |
Do you know @airtable-keyhanvakil where this landed i.e. which version was it applied to and whether it covers Node.js 14.x? |
@ashishchandr70 It looks to be in v18.2.0. I asked about how to get it backported to earlier branches in that PR. |
I had this issue with vitest, I just updated it to the latest version |
Similar issue yet again in This happened after hitting
Original comment: #6899 (comment) |
It would be useful if someone could provide a simple way to reproduce the crash. |
This is to workaround for the "FATAL ERROR: v8::FromJust Maybe value is Nothing." errors we see for our Windows and macOS test executions on Azure. The error is sporadic, but most consistently appears on Windows 2022 (Azure image '20230630.1.0' and Node v18.16.1. avajs/ava#2947 seems to suggest this is a Node.js issue as reported at nodejs/node#43304 Disabling the use of our own worker threads in minifier.js resolve the issue. Disabling worker threads in AVA resolves it too. Since we want to test our worker threads, we opted for the latter by setting the AVA option '--no-worker-threads' for all scripts executed in Azure. All this indicates an issue with using worker threads (or the workerpool package) from within workers.
This is to workaround for the "FATAL ERROR: v8::FromJust Maybe value is Nothing." errors we see for our Windows and macOS test executions on Azure. The error is sporadic, but most consistently appears on Windows 2022 (Azure image '20230630.1.0' and Node v18.16.1. avajs/ava#2947 seems to suggest this is a Node.js issue as reported at nodejs/node#43304 Disabling the use of our own worker threads in minifier.js resolve the issue. Disabling worker threads in AVA resolves it too. Since we want to test our worker threads, we opted for the latter by setting the AVA option '--no-worker-threads' for all scripts executed in Azure. All this indicates an issue with using worker threads (or the workerpool package) from within workers.
Here's a small reproducible code sample. This crashes with the error 1/5 times for me. If I keep running this over and over I consistently get the crash. import { createApplication, Request } from '@nbit/bun';
import { expect, test } from 'vitest';
const home = () => ({ hello: 'world' });
const { defineRoutes, createRequestHandler } = createApplication();
const routes = defineRoutes(app => [
app.get('/', home),
]);
const requestHandler = createRequestHandler(routes);
test('should return the home page', async () => {
const request = new Request('http://localhost/');
const response = await requestHandler(request);
expect(response.status).toBe(200);
});
|
@ImLunaHey can you try with the latest v18.x? v18.3.0 is pretty old by now. A test case without third-party dependencies would help too. |
I believe |
@ImLunaHey does disabling multi threading ( |
I join the problem with 20.15.1 |
Version
v16.14.0
Platform
Darwin 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:37 PDT 2022; root:xnu-8020.121.3~4/RELEASE_ARM64_T6000 arm64
Subsystem
No response
What steps will reproduce the bug?
Running yarn test in debug console in visual studio code
How often does it reproduce? Is there a required condition?
Everytime
What is the expected behavior?
No response
What do you see instead?
Additional information
No response
The text was updated successfully, but these errors were encountered: