Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move stream development out from core #43520

Open
ronag opened this issue Jun 21, 2022 · 9 comments
Open

Move stream development out from core #43520

ronag opened this issue Jun 21, 2022 · 9 comments
Labels
stream Issues and PRs related to the stream subsystem.

Comments

@ronag
Copy link
Member

ronag commented Jun 21, 2022

Now that https://github.com/nodejs/readable-stream is up to date with the latest node version I would like to bring up the discussion of moving development of stream out of core in a similar way we currently do with undici.

@ronag ronag added stream Issues and PRs related to the stream subsystem. tsc-agenda Issues and PRs to discuss during the meetings of the TSC. labels Jun 21, 2022
@ronag ronag changed the title Move stream development out Move stream development out from core Jun 21, 2022
@ronag
Copy link
Member Author

ronag commented Jun 21, 2022

@nodejs/streams @mcollina

@ronag
Copy link
Member Author

ronag commented Jun 21, 2022

In a practical sense this means:

@ronag
Copy link
Member Author

ronag commented Jun 21, 2022

@targos I believe we might need your help to do this.

@targos
Copy link
Member

targos commented Jun 21, 2022

Sure, on what front?

@ronag
Copy link
Member Author

ronag commented Jun 21, 2022

Sure, on what front?

Assuming there is consensus. Setting up the workflow with merging readable-streams into core similar to what we do with undici.

@mscdex
Copy link
Contributor

mscdex commented Jun 21, 2022

What benefit would moving it out of core give us?

@ronag
Copy link
Member Author

ronag commented Jun 21, 2022

Easier to develop and easier to keep the ecosystem up to date. I believe @mcollina can better articulate the benefits.

@benjamingr
Copy link
Member

I'm +0 on this

@jasnell
Copy link
Member

jasnell commented Jun 22, 2022

I'd be +1 on this with the caveat that we need to continue to carefully deal with breaking changes in the streams API. So long as that continues to be a priority, I've no problems with moving this piece out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

No branches or pull requests

6 participants